Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix first notification not showing #77

Merged
merged 4 commits into from
Jul 20, 2024

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Jul 20, 2024

The first notification data received will only be ignored if the message is from more than 3 seconds in the past

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.75%. Comparing base (0166c29) to head (7622efb).

Files Patch % Lines
lib/services/nt4_client.dart 80.00% 1 Missing ⚠️
lib/services/nt_connection.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   62.74%   62.75%           
=======================================
  Files          75       75           
  Lines        7817     7821    +4     
=======================================
+ Hits         4905     4908    +3     
- Misses       2912     2913    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872 Gold872 merged commit 189d21f into main Jul 20, 2024
5 checks passed
@Gold872 Gold872 deleted the fix-notification-initial-connection branch July 20, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant