Fix max DPS calculation issue

GoldenChrysus · Aug 1, 2020 · 9ef5f13 · 9ef5f13
1 parent e92d601
commit 9ef5f13
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,24 @@
 # Changelog
 
+## 0.20.1-alpha
+
+**Released: 2020-08-01**
+
+### Bug Fixes
+- Fixed issue where max DPS is sometimes not registered correctly due to incorrect data types
+
+### Features
+- N/A
+
+### UI Changes
+- N/A
+
+### Code Changes
+- N/A
+
+### Miscellaneous
+- N/A
+
 ## 0.20.0-alpha
 
 **Released: 2020-07-26**

diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
 	"name": "ffxiv-ember-overlay",
 	"description": "React + Redux overlay for the OverlayPlugin and ACTWebSocket plugins for Advanced Combat Tracker for use with Final Fantasy XIV.",
 	"license": "GPL-3.0-only",
-	"version": "0.20.0-alpha",
+	"version": "0.20.1-alpha",
 	"keywords": [
 		"ffxiv-overlays",
 		"ffxiv-act",

diff --git a/src/processors/GameDataProcessor.js b/src/processors/GameDataProcessor.js
@@ -57,8 +57,8 @@ class GameDataProcessor  {
 		for (let player_name in data.Combatant) {
 			data.Combatant[player_name].max_enc_dps = 0;
 
-			if (can_calculate_max && (!current_state || !current_state.internal.game.Combatant || !current_state.internal.game.Combatant[player_name] || data.Combatant[player_name].encdps > current_state.internal.game.Combatant[player_name].max_enc_dps)) {
-				data.Combatant[player_name].max_enc_dps = data.Combatant[player_name].encdps;
+			if (can_calculate_max && (!current_state || !current_state.internal.game.Combatant || !current_state.internal.game.Combatant[player_name] || +data.Combatant[player_name].encdps > current_state.internal.game.Combatant[player_name].max_enc_dps)) {
+				data.Combatant[player_name].max_enc_dps = +data.Combatant[player_name].encdps;
 			} else if (current_state && current_state.internal.game.Combatant && current_state.internal.game.Combatant[player_name]) {
 				data.Combatant[player_name].max_enc_dps = current_state.internal.game.Combatant[player_name].max_enc_dps;
 			}