This repository has been archived by the owner on Oct 4, 2019. It is now read-only.
Prevent all threads from using the same POW nonce. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nonce should be different for each thread, otherwise all threads are performing the exact same hash, which means effectively on a machine with N cores you were only actually performing 1 core's worth of work.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nonce should be different for each thread, otherwise all threads are performing the exact same hash, which means effectively on a machine with N cores you were only actually performing 1 core's worth of work.
This should hopefully bring back some fairness in mining.
Since I'm giving up my unfair advantage, I hope this comes with a bug bounty from steemit and/or golos. Please PM 'penguin' in golos or steemit chat if so, so I can say where to issue it. :)