This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Updates old homepage_url key documentation #4291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanStanion-google
added
extensions
✅ Deploy Preview for developer-chrome-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
8 tasks
dotproto
suggested changes
Dec 20, 2022
Co-authored-by: Simeon Vincent <simeonv@google.com>
Co-authored-by: Simeon Vincent <simeonv@google.com>
|
Staging build for commit af04eac started at 2023-01-17T16:17:25Z completed after 6.40 minutes. https://pr-4291-static-dot-dcc-staging.uc.r.appspot.com/ The following pages likely changed with this PR: |
jpmedley
suggested changes
Jan 3, 2023
Co-authored-by: Joe Medley <jmedley@google.com>
jpmedley
approved these changes
Jan 3, 2023
oliverdunk
suggested changes
Jan 12, 2023
There was a problem hiding this comment.
Yay for getting this updated! I left a couple of comments. From a technical POV, I think this is fine because I'm not aware of any real changes around MV3. I left a few more style-focused nits which is perhaps out of scope of a technical review but hopefully helpful.
oliverdunk
approved these changes
Jan 13, 2023
jpmedley
approved these changes
Jan 17, 2023
|
@IanStanion-google, until we get this 'Stage' bug fixed, I'll go ahead and merge your stuff. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Updates old mv2 manifest key page for mv3