Skip to content

Commit

Permalink
core: remove PWA category (#15455)
Browse files Browse the repository at this point in the history
  • Loading branch information
adrianaixba authored Apr 10, 2024
1 parent 59dd429 commit 7187606
Show file tree
Hide file tree
Showing 117 changed files with 432 additions and 13,459 deletions.
6 changes: 3 additions & 3 deletions cli/cli-flags.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ function getYargsParser(manualArgv) {
'lighthouse <url> --extra-headers=./path/to/file.json',
'Path to JSON file of HTTP Header key/value pairs to send in requests')
.example(
'lighthouse <url> --only-categories=performance,pwa',
'Only run the specified categories. Available categories: accessibility, best-practices, performance, pwa, seo')
'lighthouse <url> --only-categories=performance,seo',
'Only run the specified categories. Available categories: accessibility, best-practices, performance, seo')

// We only have the single string positional argument, the url.
.option('_', {
Expand Down Expand Up @@ -188,7 +188,7 @@ function getYargsParser(manualArgv) {
array: true,
type: 'string',
coerce: splitCommaSeparatedValues,
describe: 'Only run the specified categories. Available categories: accessibility, best-practices, performance, pwa, seo',
describe: 'Only run the specified categories. Available categories: accessibility, best-practices, performance, seo',
},
'skip-audits': {
array: true,
Expand Down
2 changes: 1 addition & 1 deletion cli/test/fixtures/esm-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

/**
* Config file for running PWA smokehouse audits for axe.
* Config file for running accessibility smokehouse audits for axe.
*/

/** @type {LH.Config} */
Expand Down
16 changes: 0 additions & 16 deletions cli/test/smokehouse/core-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ import metricsDelayedFcp from './test-definitions/metrics-delayed-fcp.js';
import metricsDelayedLcp from './test-definitions/metrics-delayed-lcp.js';
import metricsTrickyTti from './test-definitions/metrics-tricky-tti.js';
import metricsTrickyTtiLateFcp from './test-definitions/metrics-tricky-tti-late-fcp.js';
import offlineOnlineOnly from './test-definitions/offline-online-only.js';
import offlineReady from './test-definitions/offline-ready.js';
import offlineSwBroken from './test-definitions/offline-sw-broken.js';
import oopifRequests from './test-definitions/oopif-requests.js';
import oopifScripts from './test-definitions/oopif-scripts.js';
import perfBudgets from './test-definitions/perf-budgets.js';
Expand All @@ -46,11 +43,6 @@ import perfFonts from './test-definitions/perf-fonts.js';
import perfFrameMetrics from './test-definitions/perf-frame-metrics.js';
import perfPreload from './test-definitions/perf-preload.js';
import perfTraceElements from './test-definitions/perf-trace-elements.js';
import pwaAirhorner from './test-definitions/pwa-airhorner.js';
import pwaCaltrain from './test-definitions/pwa-caltrain.js';
import pwaChromestatus from './test-definitions/pwa-chromestatus.js';
import pwaRocks from './test-definitions/pwa-rocks.js';
import pwaSvgomg from './test-definitions/pwa-svgomg.js';
import redirectsClientPaintServer from './test-definitions/redirects-client-paint-server.js';
import redirectsHistoryPushState from './test-definitions/redirects-history-push-state.js';
import redirectsHttp from './test-definitions/redirects-http.js';
Expand Down Expand Up @@ -98,9 +90,6 @@ const smokeTests = [
metricsDelayedLcp,
metricsTrickyTti,
metricsTrickyTtiLateFcp,
offlineOnlineOnly,
offlineReady,
offlineSwBroken,
oopifRequests,
oopifScripts,
perfBudgets,
Expand All @@ -112,11 +101,6 @@ const smokeTests = [
perfFrameMetrics,
perfPreload,
perfTraceElements,
pwaAirhorner,
pwaCaltrain,
pwaChromestatus,
pwaRocks,
pwaSvgomg,
redirectsClientPaintServer,
redirectsHistoryPushState,
redirectsHttp,
Expand Down
4 changes: 2 additions & 2 deletions cli/test/smokehouse/frontends/smokehouse-bin.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function getDefinitionsToRun(allTestDefns, requestedIds, excludedTests) {
} else {
smokes = allTestDefns.filter(test => {
// Include all tests that *include* requested id.
// e.g. a requested 'pwa' will match 'pwa-airhorner', 'pwa-caltrain', etc
// e.g. a requested 'perf' will match 'perf-preload', 'perf-trace-elements', etc
return requestedIds.some(requestedId => test.id.includes(requestedId));
});
console.log(`Running ONLY smoketests for: ${smokes.map(t => t.id).join(' ')}\n`);
Expand Down Expand Up @@ -125,7 +125,7 @@ async function begin() {
const rawArgv = y
.help('help')
.usage('node $0 [<options>] <test-ids>')
.example('node $0 -j=1 pwa seo', 'run pwa and seo tests serially')
.example('node $0 -j=1 perf seo', 'run perf and seo tests serially')
.option('_', {
array: true,
type: 'string',
Expand Down
2 changes: 1 addition & 1 deletion cli/test/smokehouse/test-definitions/a11y.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

/**
* Config for running PWA smokehouse audits for axe.
* Config for running accessibility smokehouse audits for axe.
* @type {LH.Config}
*/
const config = {
Expand Down
110 changes: 0 additions & 110 deletions cli/test/smokehouse/test-definitions/offline-online-only.js

This file was deleted.

136 changes: 0 additions & 136 deletions cli/test/smokehouse/test-definitions/offline-ready.js

This file was deleted.

Loading

0 comments on commit 7187606

Please sign in to comment.