feedback and align with 2002

GoogleChrome · Apr 14, 2017 · 8bed784 · 8bed784
1 parent 74cc732
commit 8bed784
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/lighthouse-core/report/v2/renderer/dom.js b/lighthouse-core/report/v2/renderer/dom.js
@@ -23,6 +23,7 @@ class DOM {
    */
   constructor(document) {
     this._document = document;
+    this.templatesContext = this._document;
   }
 
  /**
@@ -48,21 +49,13 @@ class DOM {
    * @throws {Error}
    */
   cloneTemplate(selector) {
-    const template = this._retrieveTemplate(selector);
+    const template = this.templatesContext.querySelector(selector);
     if (!template) {
       throw new Error(`Template not found: template${selector}`);
     }
     return this._document.importNode(template.content, true);
   }
 
-  /**
-   * @param {string} selector
-   * @return {!DocumentFragment} The original template content
-   */
-  _retrieveTemplate(selector) {
-    return this._document.querySelector(selector);
-  }
-
   /**
    * @param {string} text
    * @return {!HTMLSpanElement}

diff --git a/lighthouse-core/report/v2/renderer/report-renderer.js b/lighthouse-core/report/v2/renderer/report-renderer.js
@@ -56,8 +56,8 @@ function formatNumber(number) {
 
 class ReportRenderer {
   /**
-   * @param {!DOM} DOM
-   * @param {!DetailsRenderer} DetailsRenderer
+   * @param {!DOM} dom
+   * @param {!DetailsRenderer} detailsRenderer
    */
   constructor(dom, detailsRenderer) {
     this._dom = dom;