core: remove duplicate-id-aria and duplicate-id-active

GoogleChrome · Mar 28, 2024 · 9e3cab1 · 9e3cab1
1 parent e3cd344
commit 9e3cab1
Show file tree

Hide file tree

Showing 57 changed files with 227 additions and 1,452 deletions.
diff --git a/cli/test/fixtures/a11y/a11y_tester.html b/cli/test/fixtures/a11y/a11y_tester.html
@@ -142,17 +142,6 @@
         <dd></dd>
       </div>
     </section>
-    <p>duplicate-id-active</p>
-    <section>
-      <textarea id="duplicate-id-active" aria-label="text1"></textarea>
-      <textarea id="duplicate-id-active" aria-label="text2"></textarea>
-    </section>
-    <p>duplicate-id-aria</p>
-    <section>
-      <div id="duplicate-id-aria" class="duplicate-id-aria"></span>
-      <div id="duplicate-id-aria"></div>
-      <input type="text" aria-labelledby="duplicate-id-aria"/>
-    </section>
     <p>empty-heading</p>
     <section>
       <h1 id="empty-heading"></h1>

diff --git a/cli/test/smokehouse/test-definitions/a11y.js b/cli/test/smokehouse/test-definitions/a11y.js
@@ -452,68 +452,6 @@ const expectations = {
 
         },
       },
-      'duplicate-id-active': {
-        score: 0,
-        details: {
-          items: [
-            {
-              node: {
-                'type': 'node',
-                'selector': 'body > section > textarea#duplicate-id-active',
-                'path': '2,HTML,1,BODY,47,SECTION,0,TEXTAREA',
-                'snippet': '<textarea id="duplicate-id-active" aria-label="text1">',
-                'explanation': 'Fix any of the following:\n  Document has active elements with the same id attribute: duplicate-id-active',
-                'nodeLabel': 'text1',
-              },
-              subItems: {
-                type: 'subitems',
-                items: [
-                  {
-                    relatedNode: {
-                      'type': 'node',
-                      'path': '2,HTML,1,BODY,47,SECTION,1,TEXTAREA',
-                      'selector': 'body > section > textarea#duplicate-id-active',
-                      'snippet': '<textarea id="duplicate-id-active" aria-label="text2">',
-                      'nodeLabel': 'text2',
-                    },
-                  },
-                ],
-              },
-            },
-          ],
-        },
-      },
-      'duplicate-id-aria': {
-        score: 1,
-        details: {
-          items: [
-            {
-              node: {
-                'type': 'node',
-                'selector': 'body > section > div#duplicate-id-aria',
-                'path': '2,HTML,1,BODY,49,SECTION,0,DIV',
-                'snippet': '<div id="duplicate-id-aria" class="duplicate-id-aria">',
-                'explanation': 'Fix any of the following:\n  Document has multiple elements referenced with ARIA with the same id attribute: duplicate-id-aria',
-                'nodeLabel': 'body > section > div#duplicate-id-aria',
-              },
-              subItems: {
-                type: 'subitems',
-                items: [
-                  {
-                    relatedNode: {
-                      'type': 'node',
-                      'path': '2,HTML,1,BODY,49,SECTION,0,DIV,0,DIV',
-                      'selector': 'body > section > div#duplicate-id-aria > div#duplicate-id-aria',
-                      'snippet': '<div id="duplicate-id-aria">',
-                      'nodeLabel': 'body > section > div#duplicate-id-aria > div#duplicate-id-aria',
-                    },
-                  },
-                ],
-              },
-            },
-          ],
-        },
-      },
       'empty-heading': {
         score: 1,
         details: {

diff --git a/core/audits/accessibility/duplicate-id-active.js b/core/audits/accessibility/duplicate-id-active.js
diff --git a/core/audits/accessibility/duplicate-id-aria.js b/core/audits/accessibility/duplicate-id-aria.js
diff --git a/core/config/default-config.js b/core/config/default-config.js
@@ -255,8 +255,6 @@ const defaultConfig = {
     'accessibility/definition-list',
     'accessibility/dlitem',
     'accessibility/document-title',
-    'accessibility/duplicate-id-active',
-    'accessibility/duplicate-id-aria',
     'accessibility/empty-heading',
     'accessibility/form-field-multiple-labels',
     'accessibility/frame-title',
@@ -536,8 +534,6 @@ const defaultConfig = {
         {id: 'definition-list', weight: 7, group: 'a11y-tables-lists'},
         {id: 'dlitem', weight: 7, group: 'a11y-tables-lists'},
         {id: 'document-title', weight: 7, group: 'a11y-names-labels'},
-        {id: 'duplicate-id-active', weight: 7, group: 'a11y-navigation'},
-        {id: 'duplicate-id-aria', weight: 10, group: 'a11y-aria'},
         {id: 'form-field-multiple-labels', weight: 3, group: 'a11y-names-labels'},
         {id: 'frame-title', weight: 7, group: 'a11y-names-labels'},
         {id: 'heading-order', weight: 3, group: 'a11y-navigation'},

diff --git a/core/gather/gatherers/accessibility.js b/core/gather/gatherers/accessibility.js
@@ -52,7 +52,6 @@ async function runA11yChecks() {
       'aria-text': {enabled: true},
       'audio-caption': {enabled: false},
       'blink': {enabled: false},
-      'duplicate-id-active': {enabled: true},
       'duplicate-id': {enabled: false},
       'empty-heading': {enabled: true},
       'frame-focusable-content': {enabled: false},