tests(devtools): use is_debug = true for local builds (#15860)

GoogleChrome · Mar 8, 2024 · ab9be18 · ab9be18
1 parent 3f7f26f
commit ab9be18
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/core/scripts/build-devtools.sh b/core/scripts/build-devtools.sh
@@ -45,9 +45,9 @@ yarn devtools "$DEVTOOLS_PATH"
 
 cd "$DEVTOOLS_PATH"
 if [[ "$CI" ]]; then
-  gn gen "out/$BUILD_FOLDER" --args='devtools_dcheck_always_on=true is_debug=false'
+  gn gen "out/$BUILD_FOLDER" --args='is_debug=false'
 else
-  gn gen "out/$BUILD_FOLDER" --args='devtools_dcheck_always_on=true is_debug=false devtools_skip_typecheck=true'
+  gn gen "out/$BUILD_FOLDER" --args='is_debug=true devtools_skip_typecheck=true'
 fi
 gclient sync
 autoninja -C "out/$BUILD_FOLDER"
diff --git a/core/test/devtools-tests/download-devtools.sh b/core/test/devtools-tests/download-devtools.sh
@@ -36,7 +36,7 @@ fetch --nohooks --no-history devtools-frontend
 cd devtools-frontend
 gclient sync
 if [[ "$CI" ]]; then
-  gn gen "out/$BUILD_FOLDER" --args='devtools_dcheck_always_on=true is_debug=false'
+  gn gen "out/$BUILD_FOLDER" --args='is_debug=false'
 else
-  gn gen "out/$BUILD_FOLDER" --args='devtools_dcheck_always_on=true is_debug=false devtools_skip_typecheck=true'
+  gn gen "out/$BUILD_FOLDER" --args='is_debug=true devtools_skip_typecheck=true'
 fi
diff --git a/core/test/devtools-tests/roll-devtools.sh b/core/test/devtools-tests/roll-devtools.sh
@@ -31,9 +31,9 @@ roll_devtools
 gclient sync --delete_unversioned_trees --reset
 
 if [[ "$CI" ]]; then
-  gn gen "out/$BUILD_FOLDER" --args='devtools_dcheck_always_on=true is_debug=false'
+  gn gen "out/$BUILD_FOLDER" --args='is_debug=false'
 else
-  gn gen "out/$BUILD_FOLDER" --args='devtools_dcheck_always_on=true is_debug=false devtools_skip_typecheck=true'
+  gn gen "out/$BUILD_FOLDER" --args='is_debug=true devtools_skip_typecheck=true'
 fi
 
 # Build devtools. By default, this creates `out/LighthouseIntegration/gen/front_end`.