tests(lantern): fix some tests not running

GoogleChrome · Jun 12, 2024 · b19a516 · b19a516
1 parent 6859c5f
commit b19a516
Show file tree

Hide file tree

Showing 9 changed files with 38 additions and 10 deletions.
diff --git a/core/lib/lantern/metrics/FirstContentfulPaint.test.js b/core/lib/lantern/metrics/FirstContentfulPaint.test.js
@@ -12,7 +12,7 @@ import {getComputationDataFromFixture} from './MetricTestUtils.js';
 
 const {FirstContentfulPaint} = Lantern.Metrics;
 
-const trace = readJson('../../../fixtures/artifacts/progressive-app/trace.json', import.meta);
+const trace = readJson('../../../test/fixtures/artifacts/progressive-app/trace.json', import.meta);
 
 describe('Metrics: Lantern FCP', () => {
   it('should compute predicted value', async () => {

diff --git a/core/lib/lantern/metrics/Interactive.test.js b/core/lib/lantern/metrics/Interactive.test.js
@@ -12,8 +12,8 @@ import {readJson} from '../../../test/test-utils.js';
 
 const {Interactive, FirstContentfulPaint, LargestContentfulPaint} = Lantern.Metrics;
 
-const trace = readJson('../../../fixtures/artifacts/progressive-app/trace.json', import.meta);
-const iframeTrace = readJson('../../../fixtures/artifacts/iframe/trace.json', import.meta);
+const trace = readJson('../../../test/fixtures/artifacts/progressive-app/trace.json', import.meta);
+const iframeTrace = readJson('../../../test/fixtures/artifacts/iframe/trace.json', import.meta);
 
 describe('Metrics: Lantern TTI', () => {
   it('should compute predicted value', async () => {

diff --git a/core/lib/lantern/metrics/LargestContentfulPaint.test.js b/core/lib/lantern/metrics/LargestContentfulPaint.test.js
@@ -12,7 +12,7 @@ import {readJson} from '../../../test/test-utils.js';
 
 const {FirstContentfulPaint, LargestContentfulPaint} = Lantern.Metrics;
 
-const trace = readJson('../../../fixtures/artifacts/paul/trace.json', import.meta);
+const trace = readJson('../../../test/fixtures/artifacts/paul/trace.json', import.meta);
 
 describe('Metrics: Lantern LCP', () => {
   it('should compute predicted value', async () => {

diff --git a/core/lib/lantern/metrics/SpeedIndex.test.js b/core/lib/lantern/metrics/SpeedIndex.test.js
@@ -10,7 +10,7 @@ import {getComputationDataFromFixture} from './MetricTestUtils.js';
 
 const {SpeedIndex, FirstContentfulPaint} = Lantern.Metrics;
 
-const trace = readJson('../../../fixtures/artifacts/progressive-app/trace.json', import.meta);
+const trace = readJson('../../../test/fixtures/artifacts/progressive-app/trace.json', import.meta);
 
 const defaultThrottling = Lantern.Simulation.Constants.throttling.mobileSlow4G;
 

diff --git a/core/lib/lantern/metrics/__snapshots__/FirstContentfulPaint.test.js.snap b/core/lib/lantern/metrics/__snapshots__/FirstContentfulPaint.test.js.snap
@@ -0,0 +1,11 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`Metrics: Lantern FCP should compute predicted value 1`] = `
+Object {
+  "optimistic": 1107,
+  "optimisticNodeTimings": 4,
+  "pessimistic": 1107,
+  "pessimisticNodeTimings": 4,
+  "timing": 1107,
+}
+`;
diff --git a/core/lib/lantern/metrics/__snapshots__/Interactive.test.js.snap b/core/lib/lantern/metrics/__snapshots__/Interactive.test.js.snap
@@ -0,0 +1,17 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`Metrics: Lantern TTI should compute predicted value 1`] = `
+Object {
+  "optimistic": 1107,
+  "pessimistic": 1134,
+  "timing": 1122,
+}
+`;
+
+exports[`Metrics: Lantern TTI should compute predicted value on iframes with substantial layout 1`] = `
+Object {
+  "optimistic": 2372,
+  "pessimistic": 2386,
+  "timing": 2379,
+}
+`;
diff --git a/core/lib/lantern/simulation/NetworkAnalyzer.test.js b/core/lib/lantern/simulation/NetworkAnalyzer.test.js
@@ -12,8 +12,8 @@ import {runTraceEngine} from '../metrics/MetricTestUtils.js';
 
 const {NetworkAnalyzer} = Lantern.Simulation;
 
-const trace = readJson('../../../fixtures/artifacts/paul/trace.json', import.meta);
-const traceWithRedirect = readJson('../../../fixtures/artifacts/redirect/trace.json', import.meta);
+const trace = readJson('../../../test/fixtures/artifacts/paul/trace.json', import.meta);
+const traceWithRedirect = readJson('../../../test/fixtures/artifacts/redirect/trace.json', import.meta);
 
 /**
  * @param {Lantern.Trace} trace

diff --git a/core/lib/lantern/simulation/Simulator.test.js b/core/lib/lantern/simulation/Simulator.test.js
@@ -8,12 +8,12 @@ import assert from 'assert/strict';
 
 import * as Lantern from '../lantern.js';
 import {readJson} from '../../../test/test-utils.js';
-import {runTraceEngine} from '../../../test/lib/lantern/metrics/MetricTestUtils.js';
+import {runTraceEngine} from '../metrics/MetricTestUtils.js';
 
 const {NetworkNode, CPUNode} = Lantern;
 const {Simulator, DNSCache} = Lantern.Simulation;
 
-const pwaTrace = readJson('../../../fixtures/artifacts/progressive-app/trace.json', import.meta);
+const pwaTrace = readJson('../../../test/fixtures/artifacts/progressive-app/trace.json', import.meta);
 
 let nextRequestId = 1;
 let nextTid = 1;

diff --git a/core/test/scripts/run-mocha-tests.js b/core/test/scripts/run-mocha-tests.js
@@ -171,7 +171,7 @@ const defaultTestMatches = [
   'cli/**/*-test.js',
   'core/**/*-test.js',
   'core/test/**/*-test-pptr.js',
-  'core/lib/lantern/*.test.js',
+  'core/lib/lantern/**/*.test.js',
   'report/**/*-test.js',
   'shared/**/*-test.js',
   'third-party/**/*-test.js',