core: remove plugins audit (#15928)

GoogleChrome · Apr 8, 2024 · c1895ac · c1895ac
1 parent e6ffdf3
commit c1895ac
Show file tree

Hide file tree

Showing 67 changed files with 25 additions and 1,008 deletions.
diff --git a/cli/test/fixtures/dobetterweb/dbw_tester.html b/cli/test/fixtures/dobetterweb/dbw_tester.html
@@ -138,7 +138,7 @@
 
 <!-- Various sites like to assign HTMLElements a custom `matches` property. See issue #5934 -->
 
-<!-- EmbeddedContent will process these elements -->
+<!-- Was for deprecated plugins audit, keeping them so smoke expectations don't change (e.g. dom-size) -->
 <object id="5934a"></object>
 <object id="5934b"></object>
 

diff --git a/cli/test/fixtures/seo/seo-failure-cases.html b/cli/test/fixtures/seo/seo-failure-cases.html
@@ -56,25 +56,5 @@ <h2>Anchor text</h2>
   <script>
     document.querySelector('.link-parent').addEventListener('click', () => {});
   </script>
-
-  <!-- FAIL(plugins): java applet on page -->
-  <applet code=HelloWorld.class width="200" height="200" id='applet'>
-    Your browser does not support the <code>applet</code> tag.
-  </applet>
-
-  <!-- FAIL(plugins): flash content on page -->
-  <object classid="clsid:d27cdb6e-ae6d-11cf-96b8-444553540000" width="590" height="90" id="adobe-embed" align="middle">
-    <param name="movie" value="movie_name.swf"/>
-    <!--[if !IE]>-->
-    <object type="application/x-shockwave-flash" data="movie_name.swf" width="590" height="90">
-      <param name="movie" value="movie_name.swf"/>
-    <!--<![endif]-->
-      <a href="http://www.adobe.com/go/getflash">
-        <img src="http://www.adobe.com/images/shared/download_buttons/get_flash_player.gif" alt="Get Adobe Flash player"/>
-      </a>
-    <!--[if !IE]>-->
-    </object>
-    <!--<![endif]-->
-  </object>
 </body>
 </html>
diff --git a/cli/test/fixtures/seo/seo-tester.html b/cli/test/fixtures/seo/seo-tester.html
@@ -66,8 +66,6 @@ <h6>2</h6>
   </script>
   <!-- override global URL - bug #5701 -->
   <script>URL = '';</script>
-  <!-- PASS(plugins): external content does not require java, flash or silverlight -->
-  <object data="test.pdf" type="application/pdf" width="300" height="200"></object>
 
   <!-- PASS(crawlable-anchors): Link with a relative path -->
   <a href="/pass">Some link</a>

diff --git a/cli/test/smokehouse/test-definitions/seo-failing.js b/cli/test/smokehouse/test-definitions/seo-failing.js
@@ -98,14 +98,6 @@ const expectations = {
           },
         },
       },
-      'plugins': {
-        score: 0,
-        details: {
-          items: {
-            length: 3,
-          },
-        },
-      },
       'canonical': {
         score: 0,
         explanation: 'Multiple conflicting URLs (https://example.com/other, https://example.com/)',

diff --git a/cli/test/smokehouse/test-definitions/seo-passing.js b/cli/test/smokehouse/test-definitions/seo-passing.js
@@ -150,9 +150,6 @@ const expectations = {
       'hreflang': {
         score: 1,
       },
-      'plugins': {
-        score: 1,
-      },
       'canonical': {
         score: 1,
       },

diff --git a/cli/test/smokehouse/test-definitions/seo-status-403.js b/cli/test/smokehouse/test-definitions/seo-status-403.js
@@ -57,9 +57,6 @@ const expectations = {
       'hreflang': {
         score: null,
       },
-      'plugins': {
-        score: null,
-      },
       'canonical': {
         score: null,
       },

diff --git a/core/audits/seo/plugins.js b/core/audits/seo/plugins.js
diff --git a/core/config/default-config.js b/core/config/default-config.js
@@ -133,7 +133,6 @@ const defaultConfig = {
     {id: 'CSSUsage', gatherer: 'css-usage'},
     {id: 'Doctype', gatherer: 'dobetterweb/doctype'},
     {id: 'DOMStats', gatherer: 'dobetterweb/domstats'},
-    {id: 'EmbeddedContent', gatherer: 'seo/embedded-content'},
     {id: 'FontSize', gatherer: 'seo/font-size'},
     {id: 'Inputs', gatherer: 'inputs'},
     {id: 'IFrameElements', gatherer: 'iframe-elements'},
@@ -329,7 +328,6 @@ const defaultConfig = {
     'seo/is-crawlable',
     'seo/robots-txt',
     'seo/hreflang',
-    'seo/plugins',
     'seo/canonical',
     'seo/manual/structured-data',
     'work-during-interaction',
@@ -615,7 +613,6 @@ const defaultConfig = {
         {id: 'hreflang', weight: 1, group: 'seo-content'},
         {id: 'canonical', weight: 1, group: 'seo-content'},
         {id: 'font-size', weight: 1, group: 'seo-mobile'},
-        {id: 'plugins', weight: 1, group: 'seo-content'},
         // Manual audits
         {id: 'structured-data', weight: 0},
       ],

diff --git a/core/gather/gatherers/seo/embedded-content.js b/core/gather/gatherers/seo/embedded-content.js