core: score of 1 for informative audits (#15689)

GoogleChrome · Jan 18, 2024 · d69c3ea · d69c3ea
1 parent e85c2ac
commit d69c3ea
Show file tree

Hide file tree

Showing 12 changed files with 111 additions and 106 deletions.
diff --git a/cli/test/smokehouse/test-definitions/a11y.js b/cli/test/smokehouse/test-definitions/a11y.js
@@ -484,7 +484,7 @@ const expectations = {
         },
       },
       'duplicate-id-aria': {
-        score: null,
+        score: 1,
         details: {
           items: [
             {
@@ -515,7 +515,7 @@ const expectations = {
         },
       },
       'empty-heading': {
-        score: null,
+        score: 1,
         details: {
           items: [
             {
@@ -531,7 +531,7 @@ const expectations = {
         },
       },
       'form-field-multiple-labels': {
-        score: null,
+        score: 1,
         scoreDisplayMode: 'informative',
         details: {
           items: [
@@ -625,7 +625,7 @@ const expectations = {
         scoreDisplayMode: 'notApplicable',
       },
       'identical-links-same-purpose': {
-        score: null,
+        score: 1,
         details: {
           items: [
             {
@@ -739,7 +739,7 @@ const expectations = {
         },
       },
       'landmark-one-main': {
-        score: null,
+        score: 1,
         details: {
           items: [
             {
@@ -931,7 +931,7 @@ const expectations = {
         },
       },
       'target-size': {
-        score: null,
+        score: 1,
         details: {
           items: [
             {

diff --git a/cli/test/smokehouse/test-definitions/dobetterweb.js b/cli/test/smokehouse/test-definitions/dobetterweb.js
@@ -459,7 +459,7 @@ const expectations = {
         },
       },
       'dom-size': {
-        score: null,
+        score: 1,
         numericValue: 154,
         details: {
           items: [

diff --git a/cli/test/smokehouse/test-definitions/perf-budgets.js b/cli/test/smokehouse/test-definitions/perf-budgets.js
@@ -67,7 +67,7 @@ const expectations = {
     finalDisplayedUrl: 'http://localhost:10200/perf/perf-budgets/load-things.html',
     audits: {
       'resource-summary': {
-        score: null,
+        score: 1,
         details: {
           items: [
             {resourceType: 'total', requestCount: 10, transferSize: '166472±1000'},
@@ -83,7 +83,7 @@ const expectations = {
         },
       },
       'performance-budget': {
-        score: null,
+        score: 1,
         details: {
           // Undefined items are asserting that the property isn't included in the table item.
           items: [

diff --git a/cli/test/smokehouse/test-definitions/perf-diagnostics-animations.js b/cli/test/smokehouse/test-definitions/perf-diagnostics-animations.js
@@ -21,7 +21,7 @@ const expectations = {
     finalDisplayedUrl: 'http://localhost:10200/perf/animations.html',
     audits: {
       'non-composited-animations': {
-        score: null,
+        score: 1,
         displayValue: '1 animated element found',
         details: {
           items: [

diff --git a/cli/test/smokehouse/test-definitions/perf-frame-metrics.js b/cli/test/smokehouse/test-definitions/perf-frame-metrics.js
@@ -67,7 +67,7 @@ const expectations = {
     finalDisplayedUrl: 'http://localhost:10200/perf/frame-metrics.html',
     audits: {
       'metrics': {
-        score: null,
+        score: 1,
         details: {
           type: 'debugdata',
           items: [

diff --git a/cli/test/smokehouse/test-definitions/perf-trace-elements.js b/cli/test/smokehouse/test-definitions/perf-trace-elements.js
@@ -189,7 +189,7 @@ const expectations = {
         },
       },
       'layout-shift-elements': {
-        score: null,
+        score: 1,
         displayValue: '2 elements found',
         details: {
           items: [
@@ -228,7 +228,7 @@ const expectations = {
         },
       },
       'long-tasks': {
-        score: null,
+        score: 1,
         details: {
           items: {
             0: {

diff --git a/core/audits/audit.js b/core/audits/audit.js
@@ -330,6 +330,10 @@ class Audit {
    * @return {number|null}
    */
   static _normalizeAuditScore(score, scoreDisplayMode, auditId) {
+    if (scoreDisplayMode === Audit.SCORING_MODES.INFORMATIVE) {
+      return 1;
+    }
+
     if (scoreDisplayMode !== Audit.SCORING_MODES.BINARY &&
         scoreDisplayMode !== Audit.SCORING_MODES.NUMERIC &&
         scoreDisplayMode !== Audit.SCORING_MODES.METRIC_SAVINGS) {

diff --git a/core/lib/lighthouse-compatibility.js b/core/lib/lighthouse-compatibility.js
@@ -36,6 +36,10 @@ function upgradeLhrForCompatibility(lhr) {
       audit.scoreDisplayMode = 'notApplicable';
     }
 
+    if (audit.scoreDisplayMode === 'informative') {
+      audit.score = 1;
+    }
+
     if (audit.details) {
       // Turn `auditDetails.type` of undefined (LHR <4.2) and 'diagnostic' (LHR <5.0)
       // into 'debugdata' (LHR ≥5.0).

diff --git a/core/test/audits/audit-test.js b/core/test/audits/audit-test.js
@@ -87,14 +87,14 @@ describe('Audit', () => {
         assert.strictEqual(auditResult.score, 1);
       });
 
-      it('override scoreDisplayMode if set on audit product', () => {
+      it('switches to INFORMATIVE and set score to 1 if set on audit product', () => {
         assert.strictEqual(NumericAudit.meta.scoreDisplayMode, Audit.SCORING_MODES.NUMERIC);
         const auditResult = Audit.generateAuditResult(NumericAudit, {
-          score: 1,
+          score: null,
           scoreDisplayMode: Audit.SCORING_MODES.INFORMATIVE,
         });
         assert.strictEqual(auditResult.scoreDisplayMode, Audit.SCORING_MODES.INFORMATIVE);
-        assert.strictEqual(auditResult.score, null);
+        assert.strictEqual(auditResult.score, 1);
       });
 
       it('switches to an ERROR and is not scored if an errorMessage is passed in', () => {