Use hostname instead of host

GoogleChrome · Apr 30, 2018 · f9b3442 · f9b3442
1 parent 9d95eeb
commit f9b3442
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lighthouse-core/audits/uses-rel-preload.js b/lighthouse-core/audits/uses-rel-preload.js
@@ -7,7 +7,7 @@
 'use strict';
 
 const Audit = require('./audit');
-const Util = require('../report/v2/renderer/util');
+const Util = require('../report/html/renderer/util');
 const URL = require('../lib/url-shim');
 const UnusedBytes = require('./byte-efficiency/byte-efficiency-audit');
 const THRESHOLD_IN_MS = 100;

diff --git a/lighthouse-core/lib/url-shim.js b/lighthouse-core/lib/url-shim.js
@@ -97,12 +97,12 @@ class URLShim extends URL {
     const urlAInfo = new URL(urlA);
     const urlBInfo = new URL(urlB);
 
-    if (!urlAInfo.host || !urlBInfo.host) {
+    if (!urlAInfo.hostname || !urlBInfo.hostname) {
       return false;
     }
 
-    const urlARootDomain = urlAInfo.host.split('.').slice(-2).join('.');
-    const urlBRootDomain = urlBInfo.host.split('.').slice(-2).join('.');
+    const urlARootDomain = urlAInfo.hostname.split('.').slice(-2).join('.');
+    const urlBRootDomain = urlBInfo.hostname.split('.').slice(-2).join('.');
 
     return urlARootDomain === urlBRootDomain;
   }

diff --git a/lighthouse-core/test/audits/uses-rel-preload-test.js b/lighthouse-core/test/audits/uses-rel-preload-test.js
@@ -11,7 +11,7 @@
 const UsesRelPreload = require('../../audits/uses-rel-preload.js');
 const assert = require('assert');
 const defaultMainResource = {
-  url: 'http://www.example.com',
+  url: 'http://www.example.com:3000',
   _endTime: 1,
 };