core: remove no-unload-listeners audit (#15874)

GoogleChrome · Mar 27, 2024 · fc7dc87 · fc7dc87
1 parent 157ff8b
commit fc7dc87
Show file tree

Hide file tree

Showing 60 changed files with 282 additions and 1,198 deletions.
diff --git a/cli/test/smokehouse/test-definitions/dobetterweb.js b/cli/test/smokehouse/test-definitions/dobetterweb.js
@@ -207,12 +207,6 @@ const expectations = {
         },
       },
     ],
-    GlobalListeners: [{
-      type: 'unload',
-      scriptId: /^\d+$/,
-      lineNumber: '>300',
-      columnNumber: '>30',
-    }],
     DevtoolsLog: {
       _includes: [
         // Ensure we are getting async call stacks.
@@ -479,20 +473,6 @@ const expectations = {
           ],
         },
       },
-      'no-unload-listeners': {
-        score: 0,
-        details: {
-          items: [{
-            source: {
-              type: 'source-location',
-              url: 'http://localhost:10200/dobetterweb/dbw_tester.html',
-              urlProvider: 'network',
-              line: '>300',
-              column: '>30',
-            },
-          }],
-        },
-      },
       'bf-cache': {
         details: {
           items: [

diff --git a/core/audits/no-unload-listeners.js b/core/audits/no-unload-listeners.js
diff --git a/core/config/default-config.js b/core/config/default-config.js
@@ -141,7 +141,6 @@ const defaultConfig = {
     {id: 'EmbeddedContent', gatherer: 'seo/embedded-content'},
     {id: 'FontSize', gatherer: 'seo/font-size'},
     {id: 'Inputs', gatherer: 'inputs'},
-    {id: 'GlobalListeners', gatherer: 'global-listeners'},
     {id: 'IFrameElements', gatherer: 'iframe-elements'},
     {id: 'ImageElements', gatherer: 'image-elements'},
     {id: 'InstallabilityErrors', gatherer: 'installability-errors'},
@@ -222,7 +221,6 @@ const defaultConfig = {
     'layout-shift-elements',
     'layout-shifts',
     'long-tasks',
-    'no-unload-listeners',
     'non-composited-animations',
     'unsized-images',
     'valid-source-maps',
@@ -605,7 +603,6 @@ const defaultConfig = {
         {id: 'doctype', weight: 1, group: 'best-practices-browser-compat'},
         {id: 'charset', weight: 1, group: 'best-practices-browser-compat'},
         // General Group
-        {id: 'no-unload-listeners', weight: 1, group: 'best-practices-general'},
         {id: 'js-libraries', weight: 0, group: 'best-practices-general'},
         {id: 'deprecations', weight: 5, group: 'best-practices-general'},
         {id: 'third-party-cookies', weight: 5, group: 'best-practices-general'},

diff --git a/core/gather/gatherers/global-listeners.js b/core/gather/gatherers/global-listeners.js
diff --git a/core/test/audits/no-unload-listeners-test.js b/core/test/audits/no-unload-listeners-test.js