Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"find element" code is duplicated in many places #11992

Closed
connorjclark opened this issue Jan 22, 2021 · 0 comments · Fixed by #15960
Closed

"find element" code is duplicated in many places #11992

connorjclark opened this issue Jan 22, 2021 · 0 comments · Fixed by #15960
Labels
P2

Comments

@connorjclark
Copy link
Collaborator

4-5 places. #11990 (comment)

Could we move all of dom.js into lib/ and import it as necessary for all of our usages?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

misc: deduplicate all the dom helpers GoogleChrome/lighthouse
2 participants
@patrickhulce @connorjclark