misc: deduplicate all the dom helpers #15960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Apr 17, 2024
| @@ -15,25 +15,13 @@ import {ReportRenderer} from '../../../report/renderer/report-renderer.js'; | |||
| import {TextEncoding} from '../../../report/renderer/text-encoding.js'; | |||
| import {renderFlowReport} from '../../../flow-report/api'; | |||
|
|
|||
| // @ts-expect-error Legacy use of report renderer | |||
| const dom = new DOM(document); | |||
There was a problem hiding this comment.
Why not just add document.documentElement to get rid of the type error?
There was a problem hiding this comment.
adamraine
approved these changes
Apr 17, 2024
|
Could it be a standalone function that these files could import and that |
|
That's a reasonable further refactor. Note that treemap uses createElement/createChildOf too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11992
This reduces 4 instances of
findto 1. I also adopted treemap's default second param to the canonical instance inDOM.