tests: update coveragePathIgnore jest configuration #10448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Mar 10, 2020
connorjclark
changed the title
that's unfortunate. I would have thought our coverage check would have caught that, but weirdly codecov doesn't show much change (-0.04%) for that PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix the OOM that happens sometimes.
I tested this PR by commenting out
coverageReporters: ['none'],from jest.config.js and then runningyarn jest "byte-eff" --ci --coverage --reporters=defaultbefore the change i saw /test/ and fixtures/ files in the output. afterwards i didnt. seems good. 😁
apparently our negative matches stopped working at some point. my guess is via jestjs/jest#7170 when we updated to jest 24. (march 2019)
(i didnt confirm this for sure, but it seems likely)
our coverage definitely changed when that landed....
https://coveralls.io/repos/109595/builds?page=180