Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(audits): remove audio-caption accessibility audit #10453

Merged
merged 3 commits into from
Mar 27, 2020
Merged

core(audits): remove audio-caption accessibility audit #10453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
101fdfe
Remove audio-caption accessibility audit
beaufortfrancois Mar 12, 2020
fece98e
Address feedback
beaufortfrancois Mar 12, 2020
108fc38
Fix tests expectations
beaufortfrancois Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,6 @@ Object {
Object {
"path": "accessibility/aria-valid-attr",
},
Object {
"path": "accessibility/audio-caption",
},
Object {
"path": "accessibility/button-name",
},
Expand Down Expand Up @@ -490,11 +487,6 @@ Object {
"id": "aria-valid-attr",
"weight": 10,
},
Object {
"group": "a11y-audio-video",
"id": "audio-caption",
"weight": 10,
},
Object {
"group": "a11y-names-labels",
"id": "button-name",
Expand Down
4 changes: 0 additions & 4 deletions lighthouse-cli/test/fixtures/a11y/a11y_tester.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@
aria-checked="0">
</div>
</section>
<p>audio-caption</p>
<section>
<audio id="audio-caption"></audio>
</section>
<p>button-name</p>
<section>
<button id="button-name"></button>
Expand Down
8 changes: 4 additions & 4 deletions lighthouse-cli/test/smokehouse/test-definitions/a11y/expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ const expectations = [
node: {
'type': 'node',
'selector': 'textarea[aria-label="text1"]',
'path': '2,HTML,1,BODY,31,SECTION,0,TEXTAREA',
'path': '2,HTML,1,BODY,29,SECTION,0,TEXTAREA',
'snippet': '<textarea id="duplicate-id-active" aria-label="text1"></textarea>',
'explanation': 'Fix any of the following:\n Document has active elements with the same id attribute: duplicate-id-active',
'nodeLabel': 'text1',
Expand All @@ -303,7 +303,7 @@ const expectations = [
node: {
'type': 'node',
'selector': '.duplicate-id-aria',
'path': '2,HTML,1,BODY,33,SECTION,0,DIV',
'path': '2,HTML,1,BODY,31,SECTION,0,DIV',
'snippet': '<div id="duplicate-id-aria" class="duplicate-id-aria">\n <div id="duplicate-id-aria"></div>\n <div aria-labelledby="duplicate-id-aria"></div>\n </div>',
'explanation': 'Fix any of the following:\n Document has multiple elements referenced with ARIA with the same id attribute: duplicate-id-aria',
'nodeLabel': 'div',
Expand All @@ -321,7 +321,7 @@ const expectations = [
node: {
'type': 'node',
'selector': '#form-field-multiple-labels',
'path': '2,HTML,1,BODY,35,SECTION,2,INPUT',
'path': '2,HTML,1,BODY,33,SECTION,2,INPUT',
'snippet': '<input type="checkbox" id="form-field-multiple-labels">',
'explanation': 'Fix all of the following:\n Multiple label elements is not widely supported in assistive technologies. Ensure the first label contains all necessary information.',
'nodeLabel': 'input',
Expand Down Expand Up @@ -354,7 +354,7 @@ const expectations = [
node: {
'type': 'node',
'selector': 'h3',
'path': '2,HTML,1,BODY,39,SECTION,1,H3',
'path': '2,HTML,1,BODY,37,SECTION,1,H3',
'snippet': '<h3>sub-sub-header</h3>',
'explanation': 'Fix any of the following:\n Heading order invalid',
'nodeLabel': 'sub-sub-header',
Expand Down
47 changes: 0 additions & 47 deletions lighthouse-core/audits/accessibility/audio-caption.js
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions lighthouse-core/config/default-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ const defaultConfig = {
'accessibility/aria-toggle-field-name',
'accessibility/aria-valid-attr-value',
'accessibility/aria-valid-attr',
'accessibility/audio-caption',
'accessibility/button-name',
'accessibility/bypass',
'accessibility/color-contrast',
Expand Down Expand Up @@ -460,7 +459,6 @@ const defaultConfig = {
{id: 'aria-toggle-field-name', weight: 3, group: 'a11y-aria'},
{id: 'aria-valid-attr-value', weight: 10, group: 'a11y-aria'},
{id: 'aria-valid-attr', weight: 10, group: 'a11y-aria'},
{id: 'audio-caption', weight: 10, group: 'a11y-audio-video'},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're still running this audit because of its wcag2a tag though, so I think we'll want to explicitly say enabled: false in our accessibility gatherer.

lighthouse/lighthouse-core/gather/gatherers/accessibility.js

Lines 34 to 51 in 40a187f

rules: {
'tabindex': {enabled: true},
'accesskeys': {enabled: true},
'heading-order': {enabled: true},
'meta-viewport': {enabled: true},
'duplicate-id': {enabled: false},
'table-fake-caption': {enabled: false},
'td-has-header': {enabled: false},
'marquee': {enabled: false},
'area-alt': {enabled: false},
'aria-dpub-role-fallback': {enabled: false},
'html-xml-lang-mismatch': {enabled: false},
'blink': {enabled: false},
'server-side-image-map': {enabled: false},
'identical-links-same-purpose': {enabled: false},
'no-autoplay-audio': {enabled: false},
'svg-img-alt': {enabled: false},
},

{id: 'button-name', weight: 10, group: 'a11y-names-labels'},
{id: 'bypass', weight: 3, group: 'a11y-navigation'},
{id: 'color-contrast', weight: 3, group: 'a11y-color-contrast'},
Expand Down
1 change: 1 addition & 0 deletions lighthouse-core/gather/gatherers/accessibility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ function runA11yChecks() {
'identical-links-same-purpose': {enabled: false},
'no-autoplay-audio': {enabled: false},
'svg-img-alt': {enabled: false},
'audio-caption': {enabled: false},
},
// @ts-ignore
}).then(axeResult => {
Expand Down
9 changes: 0 additions & 9 deletions lighthouse-core/lib/i18n/locales/ar-XB.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,6 @@
"lighthouse-core/audits/accessibility/aria-valid-attr.js | title": {
"message": "`[aria-*]` ‏‮attributes‬‏ ‏‮are‬‏ ‏‮valid‬‏ ‏‮and‬‏ ‏‮not‬‏ ‏‮misspelled‬‏"
},
"lighthouse-core/audits/accessibility/audio-caption.js | description": {
"message": "‏‮Captions‬‏ ‏‮make‬‏ ‏‮audio‬‏ ‏‮elements‬‏ ‏‮usable‬‏ ‏‮for‬‏ ‏‮deaf‬‏ ‏‮or‬‏ ‏‮hearing‬‏-‏‮impaired‬‏ ‏‮users‬‏, ‏‮providing‬‏ ‏‮critical‬‏ ‏‮information‬‏ ‏‮such‬‏ ‏‮as‬‏ ‏‮who‬‏ ‏‮is‬‏ ‏‮talking‬‏, ‏‮what‬‏ ‏‮they‬‏'‏‮re‬‏ ‏‮saying‬‏, ‏‮and‬‏ ‏‮other‬‏ ‏‮non‬‏-‏‮speech‬‏ ‏‮information‬‏. [‏‮Learn‬‏ ‏‮more‬‏](https://web.dev/audio-caption/)."
},
"lighthouse-core/audits/accessibility/audio-caption.js | failureTitle": {
"message": "`<audio>` ‏‮elements‬‏ ‏‮are‬‏ ‏‮missing‬‏ ‏‮a‬‏ `<track>` ‏‮element‬‏ ‏‮with‬‏ `[kind=\"captions\"]`."
},
"lighthouse-core/audits/accessibility/audio-caption.js | title": {
"message": "`<audio>` ‏‮elements‬‏ ‏‮contain‬‏ ‏‮a‬‏ `<track>` ‏‮element‬‏ ‏‮with‬‏ `[kind=\"captions\"]`"
},
"lighthouse-core/audits/accessibility/axe-audit.js | failingElementsHeader": {
"message": "‏‮Failing‬‏ ‏‮Elements‬‏"
},
Expand Down
9 changes: 0 additions & 9 deletions lighthouse-core/lib/i18n/locales/ar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,6 @@
"lighthouse-core/audits/accessibility/aria-valid-attr.js | title": {
"message": "سمات `[aria-*]` هي صالحة وليس بها أخطاء إملائية"
},
"lighthouse-core/audits/accessibility/audio-caption.js | description": {
"message": "تجعل مقاطع الشرح العناصر الصوتية قابلة للاستخدام للمستخدمين الصُم أو الذين يعانون من إعاقة سمعية، ما يوفّر معلومات مهمة، مثل الشخص المتحدث والحوار الذي يدور ومعلومات أخرى بخلاف الكلام. [مزيد من المعلومات](https://web.dev/audio-caption/)"
},
"lighthouse-core/audits/accessibility/audio-caption.js | failureTitle": {
"message": "عناصر `<audio>` لا تتضمّن عنصر `<track>` مع `[kind=\"captions\"]`"
},
"lighthouse-core/audits/accessibility/audio-caption.js | title": {
"message": "العناصر `<audio>` تحتوي على عنصر `<track>` مع `[kind=\"captions\"]`"
},
"lighthouse-core/audits/accessibility/axe-audit.js | failingElementsHeader": {
"message": "العناصر التي رسبت في عملية التدقيق"
},
Expand Down
9 changes: 0 additions & 9 deletions lighthouse-core/lib/i18n/locales/bg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,6 @@
"lighthouse-core/audits/accessibility/aria-valid-attr.js | title": {
"message": "Атрибутите `[aria-*]` са валидни и са изписани правилно"
},
"lighthouse-core/audits/accessibility/audio-caption.js | description": {
"message": "Надписите правят аудиоелементите използваеми за потребителите със слухови увреждания, като предоставят важна информация, например кой говори и какво казва, както и друга информация, несвързана с речта. [Научете повече](https://web.dev/audio-caption/)."
},
"lighthouse-core/audits/accessibility/audio-caption.js | failureTitle": {
"message": "За някои елементи `<audio>` липсва елемент `<track>` с `[kind=\"captions\"]`."
},
"lighthouse-core/audits/accessibility/audio-caption.js | title": {
"message": "Елементите `<audio>` съдържат елемент `<track>` с `[kind=\"captions\"]`"
},
"lighthouse-core/audits/accessibility/axe-audit.js | failingElementsHeader": {
"message": "Елементи с грешки"
},
Expand Down
9 changes: 0 additions & 9 deletions lighthouse-core/lib/i18n/locales/ca.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,6 @@
"lighthouse-core/audits/accessibility/aria-valid-attr.js | title": {
"message": "Els atributs `[aria-*]` són vàlids i estan ben escrits"
},
"lighthouse-core/audits/accessibility/audio-caption.js | description": {
"message": "Els subtítols permeten que els usuaris sords o amb discapacitat auditiva utilitzin els elements d'àudio. Així obtenen informació essencial, com ara qui parla, què diu i altres dades no verbals. [Obtén més informació](https://web.dev/audio-caption/)."
},
"lighthouse-core/audits/accessibility/audio-caption.js | failureTitle": {
"message": "Als elements `<audio>` els falta un element `<track>` amb `[kind=\"captions\"]`."
},
"lighthouse-core/audits/accessibility/audio-caption.js | title": {
"message": "Els elements `<audio>` contenen un element `<track>` amb `[kind=\"captions\"]`"
},
"lighthouse-core/audits/accessibility/axe-audit.js | failingElementsHeader": {
"message": "Elements amb errors"
},
Expand Down
9 changes: 0 additions & 9 deletions lighthouse-core/lib/i18n/locales/cs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,6 @@
"lighthouse-core/audits/accessibility/aria-valid-attr.js | title": {
"message": "Atributy `[aria-*]` jsou platné a nejsou v nich překlepy"
},
"lighthouse-core/audits/accessibility/audio-caption.js | description": {
"message": "Titulky umožňují sluchově postiženým uživatelům používat zvukové prvky tím, že jim poskytují kritické informace (například kdo mluví a co říká nebo další informace nesouvisející s řečí). [Další informace](https://web.dev/audio-caption/)"
},
"lighthouse-core/audits/accessibility/audio-caption.js | failureTitle": {
"message": "V prvcích `<audio>` chybí prvek `<track>` s atributem `[kind=\"captions\"]`."
},
"lighthouse-core/audits/accessibility/audio-caption.js | title": {
"message": "Prvky `<audio>` obsahují prvek `<track>` s atributem `[kind=\"captions\"]`"
},
"lighthouse-core/audits/accessibility/axe-audit.js | failingElementsHeader": {
"message": "Prvky, které neprošly"
},
Expand Down
9 changes: 0 additions & 9 deletions lighthouse-core/lib/i18n/locales/da.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,6 @@
"lighthouse-core/audits/accessibility/aria-valid-attr.js | title": {
"message": "`[aria-*]`-attributterne er gyldige og er stavet korrekt"
},
"lighthouse-core/audits/accessibility/audio-caption.js | description": {
"message": "Undertekster hjælper døve og hørehæmmede med at forstå lydelementer, idet de giver vigtige oplysninger som f.eks., hvem der taler, hvad de siger, og andre oplysninger, som ikke er relateret til tale. [Få flere oplysninger](https://web.dev/audio-caption/)."
},
"lighthouse-core/audits/accessibility/audio-caption.js | failureTitle": {
"message": "`<audio>`-elementerne mangler et `<track>`-element med `[kind=\"captions\"]`."
},
"lighthouse-core/audits/accessibility/audio-caption.js | title": {
"message": "`<audio>`-elementerne indeholder et `<track>`-element med `[kind=\"captions\"]`"
},
"lighthouse-core/audits/accessibility/axe-audit.js | failingElementsHeader": {
"message": "Elementer, der ikke bestod gennemgangen"
},
Expand Down
9 changes: 0 additions & 9 deletions lighthouse-core/lib/i18n/locales/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,6 @@
"lighthouse-core/audits/accessibility/aria-valid-attr.js | title": {
"message": "`[aria-*]`-Attribute sind gültig und richtig geschrieben"
},
"lighthouse-core/audits/accessibility/audio-caption.js | description": {
"message": "Durch Untertitel sind Audioelemente auch für Gehörlose und Hörgeschädigte nutzbar, da sie wichtige Informationen zur sprechenden Person und zum Inhalt des Gesprächs sowie andere nonverbale Informationen enthalten. [Weitere Informationen.](https://web.dev/audio-caption/)"
},
"lighthouse-core/audits/accessibility/audio-caption.js | failureTitle": {
"message": "Den `<audio>`-Elementen fehlt ein `<track>`-Element mit `[kind=\"captions\"]`."
},
"lighthouse-core/audits/accessibility/audio-caption.js | title": {
"message": "`<audio>`-Elemente enthalten ein `<track>`-Element mit `[kind=\"captions\"]`"
},
"lighthouse-core/audits/accessibility/axe-audit.js | failingElementsHeader": {
"message": "Fehlerhafte Elemente"
},
Expand Down
9 changes: 0 additions & 9 deletions lighthouse-core/lib/i18n/locales/el.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,6 @@
"lighthouse-core/audits/accessibility/aria-valid-attr.js | title": {
"message": "Τα χαρακτηριστικά `[aria-*]` είναι έγκυρα και δεν έχουν ορθογραφικά λάθη"
},
"lighthouse-core/audits/accessibility/audio-caption.js | description": {
"message": "Οι υπότιτλοι καθιστούν τα στοιχεία ήχου προσβάσιμα από τους χρήστες που είναι κωφοί ή έχουν προβλήματα ακοής, καθώς παρέχουν σημαντικές πληροφορίες όπως το ποιος μιλάει, το τι λέει και άλλες μη λεκτικές πληροφορίες. [Μάθετε περισσότερα](https://web.dev/audio-caption/)."
},
"lighthouse-core/audits/accessibility/audio-caption.js | failureTitle": {
"message": "Λείπει ένα στοιχείο `<track>` με `[kind=\"captions\"]` από τα στοιχεία `<audio>`."
},
"lighthouse-core/audits/accessibility/audio-caption.js | title": {
"message": "Τα στοιχεία `<audio>` περιέχουν ένα στοιχείο `<track>` με `[kind=\"captions\"]`"
},
"lighthouse-core/audits/accessibility/axe-audit.js | failingElementsHeader": {
"message": "Στοιχεία που απέτυχαν"
},
Expand Down
9 changes: 0 additions & 9 deletions lighthouse-core/lib/i18n/locales/en-GB.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,6 @@
"lighthouse-core/audits/accessibility/aria-valid-attr.js | title": {
"message": "`[aria-*]` attributes are valid and not misspelled"
},
"lighthouse-core/audits/accessibility/audio-caption.js | description": {
"message": "Captions make audio elements usable for deaf or hearing-impaired users, providing critical information such as who is talking, what they're saying and other non-speech information. [Learn more](https://web.dev/audio-caption/)."
},
"lighthouse-core/audits/accessibility/audio-caption.js | failureTitle": {
"message": "`<audio>` elements are missing a `<track>` element with `[kind=\"captions\"]`."
},
"lighthouse-core/audits/accessibility/audio-caption.js | title": {
"message": "`<audio>` elements contain a `<track>` element with `[kind=\"captions\"]`"
},
"lighthouse-core/audits/accessibility/axe-audit.js | failingElementsHeader": {
"message": "Failing elements"
},
Expand Down
9 changes: 0 additions & 9 deletions lighthouse-core/lib/i18n/locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,6 @@
"lighthouse-core/audits/accessibility/aria-valid-attr.js | title": {
"message": "`[aria-*]` attributes are valid and not misspelled"
},
"lighthouse-core/audits/accessibility/audio-caption.js | description": {
"message": "Captions make audio elements usable for deaf or hearing-impaired users, providing critical information such as who is talking, what they're saying, and other non-speech information. [Learn more](https://web.dev/audio-caption/)."
},
"lighthouse-core/audits/accessibility/audio-caption.js | failureTitle": {
"message": "`<audio>` elements are missing a `<track>` element with `[kind=\"captions\"]`."
},
"lighthouse-core/audits/accessibility/audio-caption.js | title": {
"message": "`<audio>` elements contain a `<track>` element with `[kind=\"captions\"]`"
},
"lighthouse-core/audits/accessibility/axe-audit.js | failingElementsHeader": {
"message": "Failing Elements"
},
Expand Down
9 changes: 0 additions & 9 deletions lighthouse-core/lib/i18n/locales/en-XA.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,6 @@
"lighthouse-core/audits/accessibility/aria-valid-attr.js | title": {
"message": "[ᐅ`[aria-*]`ᐊ åţţŕîбûţéš åŕé våļîð åñð ñöţ mîššþéļļéð one two three four five six seven eight nine]"
},
"lighthouse-core/audits/accessibility/audio-caption.js | description": {
"message": "[Çåþţîöñš måķé åûðîö éļéméñţš ûšåбļé ƒöŕ ðéåƒ öŕ ĥéåŕîñĝ-îmþåîŕéð ûšéŕš, þŕövîðîñĝ çŕîţîçåļ îñƒöŕmåţîöñ šûçĥ åš ŵĥö îš ţåļķîñĝ, ŵĥåţ ţĥéý'ŕé šåýîñĝ, åñð öţĥéŕ ñöñ-šþééçĥ îñƒöŕmåţîöñ. ᐅ[ᐊĻéåŕñ möŕéᐅ](https://web.dev/audio-caption/)ᐊ. one two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen sixteen seventeen eighteen nineteen twenty twentyone twentytwo twentythree twentyfour twentyfive twentysix twentyseven]"
},
"lighthouse-core/audits/accessibility/audio-caption.js | failureTitle": {
"message": "[ᐅ`<audio>`ᐊ éļéméñţš åŕé mîššîñĝ å ᐅ`<track>`ᐊ éļéméñţ ŵîţĥ ᐅ`[kind=\"captions\"]`ᐊ. one two three four five six seven eight nine ten]"
},
"lighthouse-core/audits/accessibility/audio-caption.js | title": {
"message": "[ᐅ`<audio>`ᐊ éļéméñţš çöñţåîñ å ᐅ`<track>`ᐊ éļéméñţ ŵîţĥ ᐅ`[kind=\"captions\"]`ᐊ one two three four five six seven eight nine]"
},
"lighthouse-core/audits/accessibility/axe-audit.js | failingElementsHeader": {
"message": "[Fåîļîñĝ Éļéméñţš one two]"
},
Expand Down
Loading