core(audits): mention <div> is allowed to group content in <dl> #10479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
suggested changes
Mar 18, 2020
There was a problem hiding this comment.
Thanks @Malvoz! Would you be able to run yarn update:sample-json to fix the tests?
LGTM, otherwise! 🎉
patrickhulce
suggested changes
Mar 23, 2020
There was a problem hiding this comment.
Oh hm I guess you might not have protobufs installed on your system @Malvoz doesn't look like tests are passing.
The same string change needs to be done in proto/sample_v2_round_trip.json, could be just done manually if you don't want to mess with installing protobuf dependencies, sorry for the hassle!
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
|
@patrickhulce This is passing now, sorry for a messy PR! 😅 |
patrickhulce
approved these changes
Apr 9, 2020
paulirish
pushed a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a mention that
<div>is allowed to group content in<dl>, reference: dequelabs/axe-core#1076.(Equivalent PR for updating the same thing in the axe repo: dequelabs/axe-core#2098.)