tests(legacy-javascript): exit code 1 on failure

[connorjclark]

context: #10937 (comment)

[patrickhulce]

LGTM though ironically will be blocked by #10937 because we're now catching the failure :)

[brendankenny]

process.on('unhandledRejection', err => {
  throw err;
});

also works for this, depending on how you're feeling on any particular day. I don't understand why node hasn't turned on --unhandled-rejections=strict by default despite warning about doing it for years now.

[brendankenny]

I don't understand why node hasn't turned on --unhandled-rejections=strict by default despite warning about doing it for years now.

guh, the answer is that there are a bunch of people who think that rejected promises shouldn't be treated as exceptions, which seems reasonable unless you consider a rejected promise is all you get when an exception is thrown inside of async functions, which are an increasingly large part of the population of functions in most codebases these days...

nodejs/node#33021