Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(full-page-screenshot): revise logic for determining dimensions #14920

Merged
merged 19 commits into from
Mar 8, 2024
Merged

core(full-page-screenshot): revise logic for determining dimensions #14920

merged 19 commits into from
Mar 8, 2024

Commits on Mar 27, 2023

  1. core: updated fullpage screenshot calculations.

    @alexnj
    alexnj committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    4e830f7 View commit details
    Browse the repository at this point in the history

  2. Update calculations for accounting viewport initial-scale

    @alexnj
    alexnj committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    82f9aba View commit details
    Browse the repository at this point in the history

  3. Update test to match TS definition of scale.

    @alexnj
    alexnj committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    7d87db9 View commit details
    Browse the repository at this point in the history

  4. Update review changes (Math.round + leaving width: 0) 

    Apply scaling to output + overflow smoke tests.
    @alexnj
    alexnj committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    e582a12 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Merge branch 'main' into fullpage-screenshot-recalc

    @alexnj
    alexnj authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    66ab681 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Merge branch 'main' into fullpage-screenshot-recalc

    @alexnj
    alexnj authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    59c6d8e View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Merge branch 'main' into fullpage-screenshot-recalc

    @alexnj
    alexnj authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d4b1574 View commit details
    Browse the repository at this point in the history

  2. account for macOS scrollbar

    @alexnj
    alexnj committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    189e7a3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fullpage-screenshot-recalc

    @alexnj
    alexnj authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d9f0d8c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Dont scale deviceWidth that is already scaled

    @alexnj
    alexnj committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ffe0f78 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Merge branch 'main' into fullpage-screenshot-recalc

    @adamraine
    adamraine committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    0c818aa View commit details
    Browse the repository at this point in the history

  2. update

    @adamraine
    adamraine committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    0af54f1 View commit details
    Browse the repository at this point in the history

  3. unit

    @adamraine
    adamraine committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    0ad4c7e View commit details
    Browse the repository at this point in the history

  4. fix 2

    @adamraine
    adamraine committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    59da4f2 View commit details
    Browse the repository at this point in the history

  5. ope

    @adamraine
    adamraine committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    d2fabd1 View commit details
    Browse the repository at this point in the history

  6. ope

    @adamraine
    adamraine committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    10cc442 View commit details
    Browse the repository at this point in the history

  7. ope

    @adamraine
    adamraine committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    74e8015 View commit details
    Browse the repository at this point in the history

  8. faster test

    @adamraine
    adamraine committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    468c7f9 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/main' into fullpage-screenshot-r… 

    …ecalc
    @connorjclark
    connorjclark committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    9b9a491 View commit details
    Browse the repository at this point in the history