Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add guidance level to performance audits #15025

Merged
merged 9 commits into from
Aug 30, 2023

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented Apr 28, 2023

@alexnj and I discussed changing our "difficulty" level to a "guidance" level since difficulty can be very page dependent, but we know how much guidance our audit is going to provide. These are the guidance level descriptions I used for this PR:

  • 3: We give you specifics on what to fix and we tell you how to fix it
  • 2: We give you specifics on what to fix but you will need to design a solution yourself
  • 1: No specifics just a general overview, design a solution yourself

In the future, we could consider adding a 0 level for things like manual audits or even user-timings, but I don't see it being useful right now. These guidance levels could also be applied to non-performance audits.

All of these are up for discussion, this was my initial pass. We discussed, these values are now the best consensus so far.

@adamraine adamraine requested a review from a team as a code owner April 28, 2023 17:53
@adamraine adamraine requested review from brendankenny and removed request for a team April 28, 2023 17:53
@connorjclark
Copy link
Collaborator

Should we take some group votes on difficulty again? remember this?

@adamraine
Copy link
Member Author

adamraine commented Apr 28, 2023

Should we take some group votes on difficulty again? remember this?

I'm hoping a switch to guidance would make things a little less subjective. I'm fine with making a spreadsheet to organize this and facilitate discussion, but I don't want to compute an "average" guidance level based on our individual rankings.

Edit: added a guidance level sheet to facilitate discussion

@adamraine adamraine merged commit 430d9a9 into main Aug 30, 2023
26 of 27 checks passed
@adamraine adamraine deleted the performance-guidance-level branch August 30, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants