-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report: add explodey gauge for performance category #15396
Conversation
Personal opinions and nits:
I would say no, I think it looks kinda weird. Additionally, not sure if it's intended behavior but I do like the the gauge remains "exploded" after moving the mouse away (passive state changes after interacting once)
I'm leaning yes, but we shouldn't remove the other calculator link. Some other thoughts:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the direction here, would be interested in landing alongside the new performance sorting
report/assets/styles.css
Outdated
@@ -2067,8 +2060,6 @@ details[open] .lh-clump-toggletext--hide { display: block;} | |||
stroke-width: 24; | |||
/* hack. move the hover target out of the center. ideally i tweak the r instead but that rquires considerably more math. */ | |||
transform: scale(1.15); | |||
/* I'll remove it when someone goes 'eh' */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it was I who went 'eh'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am the one who ehs
a87d7e3
to
2df7e73
Compare
lol its actually not supposed to. that was a bug i wasnt able to squash. it's inconsistent and has a lot to do if you mouse out on the bottom vs the side.
sgtm. im cool with dropping. (connor already dropped)
Yeah I get this too. I made it a lot better than it was originally but there's still some layer mgmt improvements possible.
fair. (connor changed it) |
other nits: the main score number probably shouldnt change color to match each metric on hover. it fades out pretty quick, but its distracting that it goes from gray to orange/red before fading out. let's keep as grey while exploded. check light mode on https://lighthouse-git-exploding-gauge-googlechrome.vercel.app/sample-reports/english/ looks like 'color-average-secondary' is still red in that case.. not orange. in dark mode the |
fwiw the main score text still changes color ..
lightmode it fades to average-secondary which is very reddish so you can hardly tell. |
I removed the calc link because it didn't play well with mobile (can't get the thing to hover without a tap, which would open a new tab). |
Adds the scoring calculator's neat gauge to navigation reports.
Took from https://github.com/paulirish/lh-scorecalc/tree/restore-unexpanded, but with some changes:
lh-gauge
tolh-exp-gauge
, to not conflict with LH's normal gaugemetric.acronym
instead of.id
(there is a TODO for this in the calc codebase).toFixed
and- 2*endDiffInner
thing in arc calculation which made score of 100 have a gap. idk what this was fordemo: https://lighthouse-git-exploding-gauge-googlechrome.vercel.app/sample-reports/english/