Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove PWA category #15455

Merged
merged 53 commits into from
Apr 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
9912082
rm pwa from default config
adrianaixba Sep 11, 2023
6622f8b
fix
adrianaixba Sep 12, 2023
219769c
replace pwa renderer
adrianaixba Sep 12, 2023
be98eed
nit
adrianaixba Sep 12, 2023
55c3844
fix tests
adrianaixba Sep 14, 2023
04a1def
ts type
adrianaixba Sep 14, 2023
27a25f7
nit
adrianaixba Sep 14, 2023
5147683
Merge branch 'main' into rm-pwa
adrianaixba Sep 14, 2023
b368183
fix
adrianaixba Sep 14, 2023
8ae25fe
fox
adrianaixba Sep 14, 2023
d9eb810
fix
adrianaixba Sep 14, 2023
6c915a6
fix
adrianaixba Sep 14, 2023
a2e16fc
fix
adrianaixba Sep 19, 2023
ac59ac8
Merge branch 'main' into rm-pwa
adrianaixba Sep 19, 2023
63e4387
nit
adrianaixba Sep 19, 2023
16d8a3b
rm pwa tests
adrianaixba Sep 19, 2023
d947d6e
Merge branch 'main' into rm-pwa
adrianaixba Oct 2, 2023
19a25ab
nit
adrianaixba Oct 2, 2023
84f07c8
Merge branch 'main' into rm-pwa
adrianaixba Oct 10, 2023
15d8f0e
some tests fix
adrianaixba Oct 11, 2023
78bf8d8
unit fix
adrianaixba Oct 11, 2023
535831d
Merge branch 'main' into rm-pwa
adrianaixba Oct 20, 2023
772c8f7
Merge branch 'main' into rm-pwa
adrianaixba Nov 3, 2023
b94e988
Merge branch 'main' into rm-pwa
adrianaixba Nov 21, 2023
24661c0
rearrange some audits
adrianaixba Jan 17, 2024
0947194
sample
adrianaixba Jan 17, 2024
3bdc292
Merge branch 'main' into rm-pwa
adrianaixba Mar 28, 2024
bdc1fb0
rm leftover pwa banner test
adrianaixba Mar 28, 2024
2ae4807
Merge branch 'main' into rm-pwa
adrianaixba Mar 29, 2024
4462a1f
flowww nit
adrianaixba Mar 29, 2024
9046b7a
remove themed omni
adrianaixba Mar 29, 2024
704d6e7
ui-features
adrianaixba Mar 29, 2024
68e9879
clean up
adrianaixba Apr 2, 2024
7e05549
Merge branch 'main' into rm-pwa
adrianaixba Apr 2, 2024
de8e220
bring back fireworks test
adrianaixba Apr 2, 2024
fa8bcba
rm smoke
adrianaixba Apr 2, 2024
72840ec
rm installability and other things
adrianaixba Apr 2, 2024
a3f12d5
revert to prev artifacts
adrianaixba Apr 2, 2024
c37ba58
oops
adrianaixba Apr 2, 2024
82614c8
snapshots
adrianaixba Apr 3, 2024
e13e6f9
nit
adrianaixba Apr 3, 2024
1096a7c
some test fixes
adrianaixba Apr 3, 2024
b735593
Merge branch 'main' into rm-pwa
adrianaixba Apr 3, 2024
b132986
nitss
adrianaixba Apr 3, 2024
8049722
Merge branch 'main' into rm-pwa
adrianaixba Apr 4, 2024
8762bdb
Merge branch 'main' into rm-pwa
adrianaixba Apr 5, 2024
ecb19e3
Merge branch 'main' into rm-pwa
adrianaixba Apr 5, 2024
c1e50bb
fix
adrianaixba Apr 5, 2024
7698893
Merge branch 'main' into rm-pwa
adrianaixba Apr 10, 2024
0bf17c6
rm references
adrianaixba Apr 10, 2024
d085d9b
Merge branch 'main' into rm-pwa
adrianaixba Apr 10, 2024
525f65a
oops
adrianaixba Apr 10, 2024
430f2ad
some more clean up
adrianaixba Apr 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cli/cli-flags.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ function getYargsParser(manualArgv) {
'lighthouse <url> --extra-headers=./path/to/file.json',
'Path to JSON file of HTTP Header key/value pairs to send in requests')
.example(
'lighthouse <url> --only-categories=performance,pwa',
'Only run the specified categories. Available categories: accessibility, best-practices, performance, pwa, seo')
'lighthouse <url> --only-categories=performance,seo',
'Only run the specified categories. Available categories: accessibility, best-practices, performance, seo')

// We only have the single string positional argument, the url.
.option('_', {
Expand Down Expand Up @@ -188,7 +188,7 @@ function getYargsParser(manualArgv) {
array: true,
type: 'string',
coerce: splitCommaSeparatedValues,
describe: 'Only run the specified categories. Available categories: accessibility, best-practices, performance, pwa, seo',
describe: 'Only run the specified categories. Available categories: accessibility, best-practices, performance, seo',
},
'skip-audits': {
array: true,
Expand Down
2 changes: 1 addition & 1 deletion cli/test/fixtures/esm-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

/**
* Config file for running PWA smokehouse audits for axe.
* Config file for running accessibility smokehouse audits for axe.
*/

/** @type {LH.Config} */
Expand Down
16 changes: 0 additions & 16 deletions cli/test/smokehouse/core-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ import metricsDelayedFcp from './test-definitions/metrics-delayed-fcp.js';
import metricsDelayedLcp from './test-definitions/metrics-delayed-lcp.js';
import metricsTrickyTti from './test-definitions/metrics-tricky-tti.js';
import metricsTrickyTtiLateFcp from './test-definitions/metrics-tricky-tti-late-fcp.js';
import offlineOnlineOnly from './test-definitions/offline-online-only.js';
import offlineReady from './test-definitions/offline-ready.js';
import offlineSwBroken from './test-definitions/offline-sw-broken.js';
import oopifRequests from './test-definitions/oopif-requests.js';
import oopifScripts from './test-definitions/oopif-scripts.js';
import perfBudgets from './test-definitions/perf-budgets.js';
Expand All @@ -46,11 +43,6 @@ import perfFonts from './test-definitions/perf-fonts.js';
import perfFrameMetrics from './test-definitions/perf-frame-metrics.js';
import perfPreload from './test-definitions/perf-preload.js';
import perfTraceElements from './test-definitions/perf-trace-elements.js';
import pwaAirhorner from './test-definitions/pwa-airhorner.js';
import pwaCaltrain from './test-definitions/pwa-caltrain.js';
import pwaChromestatus from './test-definitions/pwa-chromestatus.js';
import pwaRocks from './test-definitions/pwa-rocks.js';
import pwaSvgomg from './test-definitions/pwa-svgomg.js';
import redirectsClientPaintServer from './test-definitions/redirects-client-paint-server.js';
import redirectsHistoryPushState from './test-definitions/redirects-history-push-state.js';
import redirectsHttp from './test-definitions/redirects-http.js';
Expand Down Expand Up @@ -98,9 +90,6 @@ const smokeTests = [
metricsDelayedLcp,
metricsTrickyTti,
metricsTrickyTtiLateFcp,
offlineOnlineOnly,
offlineReady,
offlineSwBroken,
oopifRequests,
oopifScripts,
perfBudgets,
Expand All @@ -112,11 +101,6 @@ const smokeTests = [
perfFrameMetrics,
perfPreload,
perfTraceElements,
pwaAirhorner,
pwaCaltrain,
pwaChromestatus,
pwaRocks,
pwaSvgomg,
redirectsClientPaintServer,
redirectsHistoryPushState,
redirectsHttp,
Expand Down
4 changes: 2 additions & 2 deletions cli/test/smokehouse/frontends/smokehouse-bin.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function getDefinitionsToRun(allTestDefns, requestedIds, excludedTests) {
} else {
smokes = allTestDefns.filter(test => {
// Include all tests that *include* requested id.
// e.g. a requested 'pwa' will match 'pwa-airhorner', 'pwa-caltrain', etc
// e.g. a requested 'perf' will match 'perf-preload', 'perf-trace-elements', etc
return requestedIds.some(requestedId => test.id.includes(requestedId));
});
console.log(`Running ONLY smoketests for: ${smokes.map(t => t.id).join(' ')}\n`);
Expand Down Expand Up @@ -125,7 +125,7 @@ async function begin() {
const rawArgv = y
.help('help')
.usage('node $0 [<options>] <test-ids>')
.example('node $0 -j=1 pwa seo', 'run pwa and seo tests serially')
.example('node $0 -j=1 perf seo', 'run perf and seo tests serially')
.option('_', {
array: true,
type: 'string',
Expand Down
2 changes: 1 addition & 1 deletion cli/test/smokehouse/test-definitions/a11y.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

/**
* Config for running PWA smokehouse audits for axe.
* Config for running accessibility smokehouse audits for axe.
* @type {LH.Config}
*/
const config = {
Expand Down
110 changes: 0 additions & 110 deletions cli/test/smokehouse/test-definitions/offline-online-only.js

This file was deleted.

136 changes: 0 additions & 136 deletions cli/test/smokehouse/test-definitions/offline-ready.js

This file was deleted.

Loading
Loading