core: move transfer ratio estimate to script-helpers.js #15665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Dec 6, 2023
| * @param {LH.Crdp.Network.ResourceType=} resourceType | ||
| * @return {number} | ||
| */ | ||
| function estimateTransferSize(networkRecord, totalBytes, resourceType) { |
There was a problem hiding this comment.
Moving these helpers elsewhere seems reasonable but script-helpers.js doesn't seem like the right place. These functions can operate on any arbitrary network request not just scripts.
Maybe a better location would be static functions on NetworkRequest? There are already some functions like that.
There was a problem hiding this comment.
How about a computed artifact?
Can we land this for now, I've already got a PR on top.
adamraine
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following up to #15640, just moving duplicated things to a common place, and out of an Audit class.