Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(layout-shift-elements): mention windowing in description #15680

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented Dec 9, 2023

Closes #15423

Also updates the aggregate row to use the total impact from nodes and not the CLS metric value. This is probably a more meaningful value considering the audit isn't just focused on layout shifts that happened to be captured in the CLS window.

@adamraine adamraine requested a review from a team as a code owner December 9, 2023 00:08
@adamraine adamraine requested review from connorjclark and removed request for a team December 9, 2023 00:08
@adamraine adamraine changed the title core(layout-shift-elements): mention CLS normalization in description core(layout-shift-elements): mention CLS windowing in description Dec 11, 2023
@adamraine adamraine changed the title core(layout-shift-elements): mention CLS windowing in description core(layout-shift-elements): mention windowing in description Dec 11, 2023
@adamraine adamraine merged commit 83a73a2 into main Dec 11, 2023
29 checks passed
@adamraine adamraine deleted the ls-el-description branch December 11, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

layout-shift-elements max out at 5 elements
4 participants