Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: small renderAudit simplification #15725

Merged
merged 1 commit into from
Jan 4, 2024
Merged

report: small renderAudit simplification #15725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions report/renderer/category-renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,9 @@ export class CategoryRenderer {
* @return {HTMLElement}
*/
renderAudit(audit) {
const component = this.dom.createComponent('audit');
return /** @type {HTMLElement} */ (this.populateAuditValues(audit, component));
}

/**
* Populate an DOM tree with audit details. Used by renderAudit and renderOpportunity
* @param {LH.ReportResult.AuditRef} audit
* @param {DocumentFragment} component
* @return {!Element}
*/
populateAuditValues(audit, component) {
const strings = Globals.strings;
const auditEl = this.dom.find('.lh-audit', component);
const component = this.dom.createComponent('audit');
const auditEl = this.dom.find('div.lh-audit', component);
auditEl.id = audit.result.id;
const scoreDisplayMode = audit.result.scoreDisplayMode;

Expand Down
Loading