Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: create separate product savings type #15726

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

adamraine
Copy link
Member

Addresses #15721 (comment). This is really just reshuffling the types so that metrics can define their acronym to be any string, but the audit product still needs to be one of FCP/LCP/TBT/CLS/INP.

Follow up to #15721 and #15540

@adamraine adamraine requested a review from a team as a code owner January 4, 2024 20:53
@adamraine adamraine requested review from connorjclark and brendankenny and removed request for a team January 4, 2024 20:53
@@ -360,7 +360,7 @@ export class PerformanceCategoryRenderer extends CategoryRenderer {
textEl.textContent = Globals.strings.showRelevantAudits;

const filterChoices = [
/** @type {const} */ ({acronym: 'All'}),
/** @type {const} */ ({acronym: 'All', id: 'All'}),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was necessary because of a type error on L380. Just seemed easier to do this than figure out how to narrow the type down there.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants