-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: warning banner for PWA category deprecation #15741
Conversation
report/renderer/report-utils.js
Outdated
@@ -476,6 +476,9 @@ const UIStrings = { | |||
openInANewTabTooltip: 'Open in a new tab', | |||
/** Generic category name for all resources that could not be attributed to a 1st or 3rd party entity. */ | |||
unattributable: 'Unattributable', | |||
|
|||
/** Message communicating the removal of the PWA category. */ | |||
pwaRemovalMessage: 'Lighthouse will be deprecating the PWA category with Lighthouse version 12.0. More information about its deprecation [here](https://developer.chrome.com/blog/update-install-criteria?hl=en). For recommended PWA testing, refer to the documentation [here](https://developer.chrome.com/docs/devtools/progressive-web-apps/).', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re https://developer.chrome.com/blog/update-install-criteria?hl=en
@connorjclark @brendankenny can we just leave hl=en
in for translators. Will they change this link to use their own locale?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah this was an artifact of copying/pasting.. i can remove the ?hl=en
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They will not change that.
Do we cover the same languages? We could add this programatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like they don't cover every language we do. Let's just remove the ?hl=en
, maybe the site can automatically detect locale.
https://lighthouse-pwhq5k0h5-googlechrome.vercel.app/gh-pages/viewer/?gist=dfb70105a0eefd64866be4271423eaab