Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade puppeteer to 22.0.0 #15803

Merged
merged 7 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions cli/test/smokehouse/test-definitions/dobetterweb.js
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,6 @@ const expectations = {
},
],
GlobalListeners: [{
// Unload handlers were disabled in M122
_maxChromiumVersion: '121',
type: 'unload',
scriptId: /^\d+$/,
lineNumber: '>300',
Expand Down Expand Up @@ -308,13 +306,6 @@ const expectations = {
description: 'Failed to load resource: the server responded with a status of 404 (Not Found)',
sourceLocation: {url: 'http://localhost:10200/favicon.ico'},
},
{
// Unload handlers were disabled in M122
_minChromiumVersion: '122',
source: 'violation',
description: 'Permissions policy violation: unload is not allowed in this document.',
sourceLocation: {url: 'http://localhost:10200/dobetterweb/dbw_tester.html'},
},
],
},
},
Expand Down Expand Up @@ -387,10 +378,7 @@ const expectations = {
subItems: undefined,
},
{
// Deprecation warning was added in M121
_minChromiumVersion: '121',
// Unload handlers were disabled in M122
_maxChromiumVersion: '121',
value: 'UnloadHandler',
source: {
type: 'source-location',
Expand Down Expand Up @@ -492,8 +480,6 @@ const expectations = {
},
},
'no-unload-listeners': {
// Unload handlers were disabled in M122
_maxChromiumVersion: '121',
score: 0,
details: {
items: [{
Expand All @@ -511,8 +497,6 @@ const expectations = {
details: {
items: [
{
// Unload handlers were disabled in M122
_maxChromiumVersion: '121',
reason: 'The page has an unload handler in the main frame.',
failureType: 'Actionable',
subItems: {
Expand All @@ -522,8 +506,9 @@ const expectations = {
},
},
{
// Unload handlers create a permission request in M122
_minChromiumVersion: '122',
// This issue only appears in the DevTools runner for some reason.
// TODO: Investigate why this doesn't happen on the CLI runner.
_runner: 'devtools',
reason: 'There were permission requests upon navigating away.',
failureType: 'Pending browser support',
subItems: {
Expand Down
8 changes: 4 additions & 4 deletions cli/test/smokehouse/test-definitions/oopif-scripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,14 @@ const expectations = {
source: 'network',
},
{
// Worker requests emitted on the worker's parent target since M121.
_minChromiumVersion: '121',
// Worker requests emitted on the worker's parent target since M123.
_minChromiumVersion: '123',
src: 'http://localhost:10200/simple-worker.mjs',
source: 'network',
},
{
// Worker requests emitted on the worker's parent target since M121.
_minChromiumVersion: '121',
// Worker requests emitted on the worker's parent target since M123.
_minChromiumVersion: '123',
src: 'http://localhost:10200/simple-worker.js',
source: 'network',
},
Expand Down
4 changes: 2 additions & 2 deletions core/scripts/benchmark-plus-extras.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ async function runOctane(page) {
process.stdout.write(`Running Octane...\n`);
await page.goto('https://chromium.github.io/octane/', {waitUntil: 'networkidle0'});
await page.waitForSelector('#run-octane');
await page.waitForTimeout(5000);
await new Promise(r => setTimeout(r, 5000));
adamraine marked this conversation as resolved.
Show resolved Hide resolved
page.on('console', pageLogger);
await page.click('#run-octane');
await page.waitForFunction(() => {
Expand All @@ -48,7 +48,7 @@ async function runSpeedometer(page) {
process.stdout.write(`Running Speedometer...\n`);
await page.goto('https://browserbench.org/Speedometer2.0/', {waitUntil: 'networkidle0'});
await page.waitForSelector('#home button');
await page.waitForTimeout(5000);
await new Promise(r => setTimeout(r, 5000));
await page.click('#home button');

const loggerInterval = setInterval(async () => {
Expand Down
2 changes: 1 addition & 1 deletion core/scripts/update-flow-fixtures.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ async function waitForImagesToLoad(page) {
assert.deepStrictEqual(completeImages, firstRunImages);

// Next check we haven't added any new images in the quiet window.
await page.waitForTimeout(QUIET_WINDOW);
await new Promise(r => setTimeout(r, QUIET_WINDOW));
const secondRunImages = await getImageLoadingStates();
assert.deepStrictEqual(secondRunImages, firstRunImages);
}, TIMEOUT);
Expand Down
4 changes: 2 additions & 2 deletions core/test/scenarios/api-test-pptr.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ describe('Individual modes API', function() {
await setupTestPage();

// Wait long enough to ensure a paint after button interaction.
await state.page.waitForTimeout(200);
await new Promise(r => setTimeout(r, 200));

const result = await run.endTimespan();
if (!result) throw new Error('Lighthouse failed to produce a result');
Expand Down Expand Up @@ -139,7 +139,7 @@ describe('Individual modes API', function() {
await page.waitForSelector('input');

// Wait long enough to ensure a paint after button interaction.
await page.waitForTimeout(200);
await new Promise(r => setTimeout(r, 200));

const result = await run.endTimespan();

Expand Down
1 change: 0 additions & 1 deletion core/test/scenarios/pptr-test-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ function createTestState() {

before(async () => {
this.browser = await puppeteer.launch({
headless: 'new',
executablePath: getChromePath(),
ignoreDefaultArgs: ['--enable-automation'],
});
Expand Down
1 change: 0 additions & 1 deletion flow-report/test/flow-report-pptr-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ describe('Lighthouse Flow Report', () => {

before(async () => {
browser = await puppeteer.launch({
headless: 'new',
executablePath: getChromePath(),
});
page = await browser.newPage();
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
"pako": "^2.0.3",
"preact": "^10.7.2",
"pretty-json-stringify": "^0.0.2",
"puppeteer": "^21.7.0",
"puppeteer": "^22.0.0",
"resolve": "^1.22.1",
"rollup": "^2.52.7",
"rollup-plugin-polyfill-node": "^0.12.0",
Expand Down Expand Up @@ -200,7 +200,7 @@
"open": "^8.4.0",
"parse-cache-control": "1.0.1",
"ps-list": "^8.0.0",
"puppeteer-core": "^21.7.0",
"puppeteer-core": "^22.0.0",
"robots-parser": "^3.0.1",
"semver": "^5.3.0",
"speedline-core": "^1.4.3",
Expand Down
2 changes: 2 additions & 0 deletions types/internal/rxjs.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ declare module 'rxjs' {
export const ignoreElements: any;
export const map: any;
export const mergeMap: any;
export const mergeScan: any;
export const raceWith: any;
export const retry: any;
export const tap: any;
Expand All @@ -25,6 +26,7 @@ declare module 'rxjs' {
export const delay: any;
export const startWith: any;
export const switchMap: any;
export const take: any;
export const bufferCount: any;
export const concatMap: any;
export const lastValueFrom: any;
Expand Down
71 changes: 38 additions & 33 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1138,10 +1138,10 @@
resolved "https://registry.yarnpkg.com/@protobufjs/utf8/-/utf8-1.1.0.tgz#a777360b5b39a1a2e5106f8e858f2fd2d060c570"
integrity sha1-p3c2C1s5oaLlEG+OhY8v0tBgxXA=

"@puppeteer/browsers@1.9.1":
version "1.9.1"
resolved "https://registry.yarnpkg.com/@puppeteer/browsers/-/browsers-1.9.1.tgz#384ee8b09786f0e8f62b1925e4c492424cb549ee"
integrity sha512-PuvK6xZzGhKPvlx3fpfdM2kYY3P/hB1URtK8wA7XUJ6prn6pp22zvJHu48th0SGcHL9SutbPHrFuQgfXTFobWA==
"@puppeteer/browsers@2.0.0":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@puppeteer/browsers/-/browsers-2.0.0.tgz#3646d2a465c112eac21510d43b21c828612118f9"
integrity sha512-3PS82/5+tnpEaUWonjAFFvlf35QHF15xqyGd34GBa5oP5EPVfFXRsbSxIGYf1M+vZlqBZ3oxT1kRg9OYhtt8ng==
dependencies:
debug "4.3.4"
extract-zip "2.0.1"
Expand Down Expand Up @@ -2333,13 +2333,13 @@ chrome-launcher@^1.1.0:
is-wsl "^2.2.0"
lighthouse-logger "^2.0.1"

chromium-bidi@0.5.2:
version "0.5.2"
resolved "https://registry.yarnpkg.com/chromium-bidi/-/chromium-bidi-0.5.2.tgz#358b03bb7c53e0f8d0fd77d596ea67ee30f7ff06"
integrity sha512-PbVOSddxgKyj+JByqavWMNqWPCoCaT6XK5Z1EFe168sxnB/BM51LnZEPXSbFcFAJv/+u2B4XNTs9uXxy4GW3cQ==
chromium-bidi@0.5.8:
version "0.5.8"
resolved "https://registry.yarnpkg.com/chromium-bidi/-/chromium-bidi-0.5.8.tgz#5053038425c062ed34b9bc973e84e79de0a5cef0"
integrity sha512-blqh+1cEQbHBKmok3rVJkBlBxt9beKBgOsxbFgs7UJcoVbbeZ+K7+6liAsjgpc8l1Xd55cQUy14fXZdGSb4zIw==
dependencies:
mitt "3.0.1"
urlpattern-polyfill "9.0.0"
urlpattern-polyfill "10.0.0"

ci-info@^3.2.0:
version "3.3.1"
Expand Down Expand Up @@ -2668,15 +2668,15 @@ core-util-is@1.0.2, core-util-is@~1.0.0:
resolved "https://registry.yarnpkg.com/core-util-is/-/core-util-is-1.0.2.tgz#b5fd54220aa2bc5ab57aab7140c940754503c1a7"
integrity sha1-tf1UIgqivFq1eqtxQMlAdUUDwac=

cosmiconfig@8.3.6:
version "8.3.6"
resolved "https://registry.yarnpkg.com/cosmiconfig/-/cosmiconfig-8.3.6.tgz#060a2b871d66dba6c8538ea1118ba1ac16f5fae3"
integrity sha512-kcZ6+W5QzcJ3P1Mt+83OUv/oHFqZHIx8DuxG6eZ5RGMERoLqp4BuGjhHLYGK+Kf5XVkQvqBSmAy/nGWN3qDgEA==
cosmiconfig@9.0.0:
version "9.0.0"
resolved "https://registry.yarnpkg.com/cosmiconfig/-/cosmiconfig-9.0.0.tgz#34c3fc58287b915f3ae905ab6dc3de258b55ad9d"
integrity sha512-itvL5h8RETACmOTFc4UfIyB2RfEHi71Ax6E/PivVxq9NseKbOWpeyHEOIbmAw1rs8Ak0VursQNww7lf7YtUwzg==
dependencies:
env-paths "^2.2.1"
import-fresh "^3.3.0"
js-yaml "^4.1.0"
parse-json "^5.2.0"
path-type "^4.0.0"

cosmiconfig@^5.1.0:
version "5.2.1"
Expand Down Expand Up @@ -2921,7 +2921,7 @@ delayed-stream@~1.0.0:
resolved "https://registry.yarnpkg.com/delayed-stream/-/delayed-stream-1.0.0.tgz#df3ae199acadfb7d440aaae0b29e2272b24ec619"
integrity sha1-3zrhmayt+31ECqrgsp4icrJOxhk=

devtools-protocol@0.0.1203626, devtools-protocol@0.0.1211954:
devtools-protocol@0.0.1211954, devtools-protocol@0.0.1232444:
version "0.0.1211954"
resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.1211954.tgz#86ea77d011baab619fb096fc426fd8633ad2ef9b"
integrity sha512-f6BRhngr9wpHN8omZOoSaEJFscTL+tjNhmeBqHHC3CZ3K2N75sDeKXZeTkAEkTCcrusDatfwjRRBh0uz4ov/sA==
Expand Down Expand Up @@ -3024,6 +3024,11 @@ enquirer@^2.3.5, enquirer@^2.3.6:
dependencies:
ansi-colors "^4.1.1"

env-paths@^2.2.1:
version "2.2.1"
resolved "https://registry.yarnpkg.com/env-paths/-/env-paths-2.2.1.tgz#420399d416ce1fbe9bc0a07c62fa68d67fd0f8f2"
integrity sha512-+h1lkLKhZMTYjog1VEpJNG7NZJWcuc2DDk/qsqSTRRCOXiLjeQ1d1/udrUGhqMxUgAlwKNZ0cf2uqan5GLuS2A==

error-ex@^1.3.1:
version "1.3.2"
resolved "https://registry.yarnpkg.com/error-ex/-/error-ex-1.3.2.tgz#b4ac40648107fdcdcfae242f428bea8a14d4f1bf"
Expand Down Expand Up @@ -6029,26 +6034,26 @@ punycode@^2.1.0, punycode@^2.1.1:
resolved "https://registry.yarnpkg.com/punycode/-/punycode-2.1.1.tgz#b58b010ac40c22c5657616c8d2c2c02c7bf479ec"
integrity sha512-XRsRjdf+j5ml+y/6GKHPZbrF/8p2Yga0JPtdqTIY2Xe5ohJPD9saDJJLPvp9+NSBprVvevdXZybnj2cv8OEd0A==

puppeteer-core@21.7.0, puppeteer-core@^21.7.0:
version "21.7.0"
resolved "https://registry.yarnpkg.com/puppeteer-core/-/puppeteer-core-21.7.0.tgz#c0abb98cbd17dbd7ee317b4257958337fa25d2c7"
integrity sha512-elPYPozrgiM3phSy7VDUJCVWQ07SPnOm78fpSaaSNFoQx5sur/MqhTSro9Wz8lOEjqCykGC6WRkwxDgmqcy1dQ==
puppeteer-core@22.0.0, puppeteer-core@^22.0.0:
version "22.0.0"
resolved "https://registry.yarnpkg.com/puppeteer-core/-/puppeteer-core-22.0.0.tgz#f46420adac6f7be076a1f7a751c8d829461b55d2"
integrity sha512-S3s91rLde0A86PWVeNY82h+P0fdS7CTiNWAicCVH/bIspRP4nS2PnO5j+VTFqCah0ZJizGzpVPAmxVYbLxTc9w==
dependencies:
"@puppeteer/browsers" "1.9.1"
chromium-bidi "0.5.2"
"@puppeteer/browsers" "2.0.0"
chromium-bidi "0.5.8"
cross-fetch "4.0.0"
debug "4.3.4"
devtools-protocol "0.0.1203626"
devtools-protocol "0.0.1232444"
ws "8.16.0"

puppeteer@^21.7.0:
version "21.7.0"
resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-21.7.0.tgz#c4b46ef28a2986f9c536eb086ab47c8dea80e4f9"
integrity sha512-Yy+UUy0b9siJezbhHO/heYUoZQUwyqDK1yOQgblTt0l97tspvDVFkcW9toBlnSvSfkDmMI3Dx9cZL6R8bDArHA==
puppeteer@^22.0.0:
version "22.0.0"
resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-22.0.0.tgz#e2eb456c667ffb165079f4fb0b6936dd6c9ccf36"
integrity sha512-zYVnjwJngnSB4dbkWp7DHFSIc3nqHvZzrdHyo9+ugV1nq1Lm8obOMcmCFaGfR3PJs0EmYNz+/skBeO45yvASCQ==
dependencies:
"@puppeteer/browsers" "1.9.1"
cosmiconfig "8.3.6"
puppeteer-core "21.7.0"
"@puppeteer/browsers" "2.0.0"
cosmiconfig "9.0.0"
puppeteer-core "22.0.0"

q@^1.5.1:
version "1.5.1"
Expand Down Expand Up @@ -7217,10 +7222,10 @@ urix@^0.1.0:
resolved "https://registry.yarnpkg.com/urix/-/urix-0.1.0.tgz#da937f7a62e21fec1fd18d49b35c2935067a6c72"
integrity sha1-2pN/emLiH+wf0Y1Js1wpNQZ6bHI=

urlpattern-polyfill@9.0.0:
version "9.0.0"
resolved "https://registry.yarnpkg.com/urlpattern-polyfill/-/urlpattern-polyfill-9.0.0.tgz#bc7e386bb12fd7898b58d1509df21d3c29ab3460"
integrity sha512-WHN8KDQblxd32odxeIgo83rdVDE2bvdkb86it7bMhYZwWKJz0+O0RK/eZiHYnM+zgt/U7hAHOlCQGfjjvSkw2g==
urlpattern-polyfill@10.0.0:
version "10.0.0"
resolved "https://registry.yarnpkg.com/urlpattern-polyfill/-/urlpattern-polyfill-10.0.0.tgz#f0a03a97bfb03cdf33553e5e79a2aadd22cac8ec"
integrity sha512-H/A06tKD7sS1O1X2SshBVeA5FLycRpjqiBeqGKmBwBDBy28EnRjORxTNe269KSSr5un5qyWi1iL61wLxpd+ZOg==

use@^3.1.0:
version "3.1.0"
Expand Down
Loading