-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade trace_engine and drop manually written types #15810
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
)); | ||
// TODO: use TraceEngine.TraceProcessor.createWithAllHandlers above. | ||
return /** @type {import('@paulirish/trace_engine').Handlers.Types.TraceParseData} */( | ||
engine.data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will follow up with this change. Didn't want a behavior change with this patch.
await engine.parse(/** @type {import('@paulirish/trace_engine').Types.TraceEvents.TraceEventData[]} */ ( | ||
traceEvents | ||
)); | ||
// TODO: use TraceEngine.TraceProcessor.createWithAllHandlers above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems alright.
rootcauses is getting kinda gnarly but.. i guess that just happens with DOM nodes.
core/gather/gatherers/root-causes.js
Outdated
} | ||
}, | ||
/** @param {string} url */ | ||
// @ts-expect-error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you add a comment explaining this @ts-expect-error
We modified the trace_engine lib to publish many JS files instead of bundling, so we could easily package types. Can now delete
types/trace-engine.d.ts
.Some churn, it comes from the trace event types being less ergonomic than our own. Also from more specific types than what I wrote manually.