core(lantern): put types in namespace #15850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
force-pushed
the
lantern-types
branch
from
a384a91
to
8d78a1e
Compare
connorjclark
changed the title
adamraine
approved these changes
Mar 5, 2024
| @@ -132,6 +132,7 @@ declare module Gatherer { | |||
| GathererInstance<Exclude<TDependencies, DefaultDependenciesKey>> | |||
| type AnyGathererInstance = GathererInstanceExpander<Gatherer.DependencyKey> | |||
|
|
|||
| // TODO(15841): use from lantern.d.ts | |||
There was a problem hiding this comment.
Why can't this be done in this PR?
There was a problem hiding this comment.
smaller prs are easy to make and to review
here, I anticipate getting the types to still be correct might be a challenge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15841
Puts Lantern.NetworkRequest in a namespace, instead of doing something hacky with
lantern.js.Also puts the Simulation related types in lantern.d.ts. Follow-up work remains to remove from gatherer.d.ts