Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(devtools): use is_debug = true for local builds #15860

Merged
merged 1 commit into from
Mar 8, 2024
Merged

tests(devtools): use is_debug = true for local builds #15860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/scripts/build-devtools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ yarn devtools "$DEVTOOLS_PATH"

cd "$DEVTOOLS_PATH"
if [[ "$CI" ]]; then
gn gen "out/$BUILD_FOLDER" --args='devtools_dcheck_always_on=true is_debug=false'
gn gen "out/$BUILD_FOLDER" --args='is_debug=false'
else
gn gen "out/$BUILD_FOLDER" --args='devtools_dcheck_always_on=true is_debug=false devtools_skip_typecheck=true'
gn gen "out/$BUILD_FOLDER" --args='is_debug=true devtools_skip_typecheck=true'
fi
gclient sync
autoninja -C "out/$BUILD_FOLDER"
4 changes: 2 additions & 2 deletions core/test/devtools-tests/download-devtools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ fetch --nohooks --no-history devtools-frontend
cd devtools-frontend
gclient sync
if [[ "$CI" ]]; then
gn gen "out/$BUILD_FOLDER" --args='devtools_dcheck_always_on=true is_debug=false'
gn gen "out/$BUILD_FOLDER" --args='is_debug=false'
else
gn gen "out/$BUILD_FOLDER" --args='devtools_dcheck_always_on=true is_debug=false devtools_skip_typecheck=true'
gn gen "out/$BUILD_FOLDER" --args='is_debug=true devtools_skip_typecheck=true'
fi
4 changes: 2 additions & 2 deletions core/test/devtools-tests/roll-devtools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ roll_devtools
gclient sync --delete_unversioned_trees --reset

if [[ "$CI" ]]; then
gn gen "out/$BUILD_FOLDER" --args='devtools_dcheck_always_on=true is_debug=false'
gn gen "out/$BUILD_FOLDER" --args='is_debug=false'
else
gn gen "out/$BUILD_FOLDER" --args='devtools_dcheck_always_on=true is_debug=false devtools_skip_typecheck=true'
gn gen "out/$BUILD_FOLDER" --args='is_debug=true devtools_skip_typecheck=true'
fi

# Build devtools. By default, this creates `out/LighthouseIntegration/gen/front_end`.
Expand Down
Loading