Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: use "processing duration" instead of "processing time" for INP #15893

Merged
merged 3 commits into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/audits/work-during-interaction.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
/** Label for a column in a data table; entries will be information on the time that the browser is delayed before responding to user input. Ideally fits within a ~40 character limit. */
inputDelay: 'Input delay',
/** Label for a column in a data table; entries will be information on the time taken by code processing user input that delays a response to the user. Ideally fits within a ~40 character limit. */
processingTime: 'Processing time',
processingDuration: 'Processing duration',
/** Label for a column in a data table; entries will be information on the time that the browser is delayed before presenting a response to user input on screen. Ideally fits within a ~40 character limit. */
presentationDelay: 'Presentation delay',
/**
Expand Down Expand Up @@ -115,7 +115,7 @@
const endTs = startTs + interactionData.duration * 1000;
return {
inputDelay: {startTs, endTs: processingStartTs},
processingTime: {startTs: processingStartTs, endTs: processingEndTs},
processingDuration: {startTs: processingStartTs, endTs: processingEndTs},

Check warning on line 118 in core/audits/work-during-interaction.js

View check run for this annotation

Codecov / codecov/patch

core/audits/work-during-interaction.js#L118

Added line #L118 was not covered by tests
presentationDelay: {startTs: processingEndTs, endTs},
};
}
Expand Down
6 changes: 3 additions & 3 deletions core/test/audits/work-during-interaction-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@ Object {
},
Object {
"phase": Object {
"formattedDefault": "Processing time",
"i18nId": "core/audits/work-during-interaction.js | processingTime",
"formattedDefault": "Processing duration",
"i18nId": "core/audits/work-during-interaction.js | processingDuration",
"values": undefined,
},
"subItems": Object {
Expand Down Expand Up @@ -237,7 +237,7 @@ Object {
"endTs": 633282934296,
"startTs": 633282649296,
},
"processingTime": Object {
"processingDuration": Object {
"endTs": 633282649296,
"startTs": 633282608296,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10818,7 +10818,7 @@
}
},
{
"phase": "Processing time",
"phase": "Processing duration",
"total": 33,
"subItems": {
"type": "subitems",
Expand Down Expand Up @@ -10876,7 +10876,7 @@
"startTs": 183718309017,
"endTs": 183718325017
},
"processingTime": {
"processingDuration": {
"startTs": 183718325017,
"endTs": 183718358017
},
Expand Down Expand Up @@ -12614,7 +12614,7 @@
"core/audits/work-during-interaction.js | inputDelay": [
"audits[work-during-interaction].details.items[1].items[0].phase"
],
"core/audits/work-during-interaction.js | processingTime": [
"core/audits/work-during-interaction.js | processingDuration": [
"audits[work-during-interaction].details.items[1].items[1].phase"
],
"core/audits/work-during-interaction.js | presentationDelay": [
Expand Down
2 changes: 1 addition & 1 deletion shared/localization/locales/ar-XB.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/ar.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/bg.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/ca.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/cs.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/da.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/de.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/el.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/en-GB.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions shared/localization/locales/en-US.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/en-XA.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions shared/localization/locales/en-XL.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/es-419.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/es.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/fi.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/fil.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/fr.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/he.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/hi.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/hr.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/hu.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/id.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/it.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/ja.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/ko.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/lt.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/lv.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/nl.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/no.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/pl.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/pt-PT.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/pt.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/ro.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/ru.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/sk.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shared/localization/locales/sl.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading