core: deprecate overallSavingsMs
#15902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15522
This PR also updates several audits that were still using the TTI graph or entire PDG to compute
overallSavingsMs. Now those audits will just use their LCP savings to fill outoverallSavingsMsinstead.Also, turns out we were still using
overallSavingsMsin the flow report to sort audits in the summary page tooltip. Would be nice to use the same sort order as the performance category but that isn't a super high priority. This PR just does a simple sort by score then sort by LCP savings.