core: remove tap-targets and show target-size in a11y
#15906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Apr 1, 2024
| @@ -126,7 +125,6 @@ const smokeTests = [ | |||
| seoFailing, | |||
| seoPassing, | |||
| seoStatus403, | |||
| seoTapTargets, | |||
There was a problem hiding this comment.
There is a decent amount of tap targets coverage in this test, but I don't think we need to verify the target size logic since it's coming from axe. There is already a small target-size check in the a11y smoke test.
|
ctrl+f tap-targets - found more in dbw tester.html |
connorjclark
approved these changes
Apr 1, 2024
adamraine
changed the title
tap-targets from SEO and show target-size in a11ytap-targets and show target-size in a11y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12345