Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(service-worker): remove service-worker gatherer #15942

Merged
merged 2 commits into from
Apr 12, 2024
Merged

core(service-worker): remove service-worker gatherer #15942

merged 2 commits into from
Apr 12, 2024

Conversation

adrianaixba
Copy link
Collaborator

continuation of the PWA category + unused gatherers removal: #15535

@adrianaixba adrianaixba marked this pull request as ready for review April 11, 2024 22:55
@adrianaixba adrianaixba requested a review from a team as a code owner April 11, 2024 22:55
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several other references I found:

'core/test/gather/gatherers/service-worker-test.js',

await td.replaceEsm('../gather/driver/service-workers.js', {
getServiceWorkerVersions: jestMock.fn().mockResolvedValue({versions: []}),
getServiceWorkerRegistrations: jestMock.fn().mockResolvedValue({registrations: []}),
});

/** Version information for all ServiceWorkers active after the first page load. */
ServiceWorker: {versions: Crdp.ServiceWorker.ServiceWorkerVersion[], registrations: Crdp.ServiceWorker.ServiceWorkerRegistration[]};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants