Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(aria-allowed-role): fix title and description #16042

Merged
merged 1 commit into from
Jun 5, 2024
Merged

core(aria-allowed-role): fix title and description #16042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions core/audits/accessibility/aria-allowed-role.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,14 @@ import AxeAudit from './axe-audit.js';
import * as i18n from '../../lib/i18n/i18n.js';

const UIStrings = {
/** Title of an accesibility audit that evaluates if the ARIA role attributes are valid for the HTML element. This title is descriptive of the successful state and is shown to users when no user action is required. */
title: 'Values assigned to `role=""` are valid ARIA roles.',
/** Title of an accesibility audit that evaluates if the ARIA role attributes are valid for the HTML element. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
failureTitle: 'Values assigned to `role=""` are not valid ARIA roles.',
/** Title of an accessibility audit that evaluates if the ARIA role attributes are valid for the HTML element. This title is descriptive of the successful state and is shown to users when no user action is required. */
title: 'Uses ARIA roles only on compatible elements',
/** Title of an accessibility audit that evaluates if the ARIA role attributes are valid for the HTML element. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
failureTitle: 'Uses ARIA roles on incompatible elements',
/** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. The last sentence starting with 'Learn' becomes link text to additional documentation. */
description: 'ARIA `role`s enable assistive technologies to know the role of each element on ' +
'the web page. If the `role` values are misspelled, not existing ARIA `role` values, or ' +
'abstract roles, then the purpose of the element will not be communicated to users of ' +
'assistive technologies. ' +
'[Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role).',
description: 'Many HTML elements can only be assigned certain ARIA roles. Using ARIA ' +
'roles where they are not allowed can interfere with the accessibility of the web page. ' +
'[Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role).',
};

const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
Expand Down
12 changes: 6 additions & 6 deletions core/test/fixtures/user-flows/reports/sample-flow-result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2220,8 +2220,8 @@
},
"aria-allowed-role": {
"id": "aria-allowed-role",
"title": "Values assigned to `role=\"\"` are valid ARIA roles.",
"description": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role).",
"title": "Uses ARIA roles only on compatible elements",
"description": "Many HTML elements can only be assigned certain ARIA roles. Using ARIA roles where they are not allowed can interfere with the accessibility of the web page. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role).",
"score": 1,
"scoreDisplayMode": "binary",
"details": {
Expand Down Expand Up @@ -12591,8 +12591,8 @@
},
"aria-allowed-role": {
"id": "aria-allowed-role",
"title": "Values assigned to `role=\"\"` are valid ARIA roles.",
"description": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role).",
"title": "Uses ARIA roles only on compatible elements",
"description": "Many HTML elements can only be assigned certain ARIA roles. Using ARIA roles where they are not allowed can interfere with the accessibility of the web page. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role).",
"score": 1,
"scoreDisplayMode": "binary",
"details": {
Expand Down Expand Up @@ -19954,8 +19954,8 @@
},
"aria-allowed-role": {
"id": "aria-allowed-role",
"title": "Values assigned to `role=\"\"` are valid ARIA roles.",
"description": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role).",
"title": "Uses ARIA roles only on compatible elements",
"description": "Many HTML elements can only be assigned certain ARIA roles. Using ARIA roles where they are not allowed can interfere with the accessibility of the web page. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role).",
"score": 1,
"scoreDisplayMode": "binary",
"details": {
Expand Down
4 changes: 2 additions & 2 deletions core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2906,8 +2906,8 @@
},
"aria-allowed-role": {
"id": "aria-allowed-role",
"title": "Values assigned to `role=\"\"` are valid ARIA roles.",
"description": "ARIA `role`s enable assistive technologies to know the role of each element on the web page. If the `role` values are misspelled, not existing ARIA `role` values, or abstract roles, then the purpose of the element will not be communicated to users of assistive technologies. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role).",
"title": "Uses ARIA roles only on compatible elements",
"description": "Many HTML elements can only be assigned certain ARIA roles. Using ARIA roles where they are not allowed can interfere with the accessibility of the web page. [Learn more about ARIA roles](https://dequeuniversity.com/rules/axe/4.9/aria-allowed-role).",
"score": 1,
"scoreDisplayMode": "binary",
"details": {
Expand Down
6 changes: 3 additions & 3 deletions shared/localization/locales/en-US.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions shared/localization/locales/en-XL.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading