core(lantern): use LCP instead of FMP for TTI simulation bounds #16046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Jun 6, 2024
csswizardry
reviewed
Sep 3, 2024
| @@ -18,7 +18,7 @@ const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings); | |||
|
|
|||
| /** | |||
| * @fileoverview This audit identifies the time the page is "consistently interactive". | |||
| * Looks for the first period of at least 5 seconds after FMP where both CPU and network were quiet, | |||
| * Looks for the first period of at least 5 seconds after FCP where both CPU and network were quiet, | |||
There was a problem hiding this comment.
yup, fixed over in #16173. thank ya.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15841
FMP is old, and we don't want to add it to trace engine or RPP. So let's replace its usage in Lantern with LCP.
Things happen to improve with our test database. whatever.