Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(lantern): remove usage of computed PageDependencyGraph #16063

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

connorjclark
Copy link
Collaborator

ref #15841

@connorjclark connorjclark requested a review from a team as a code owner June 11, 2024 21:12
@connorjclark connorjclark requested review from adamraine and removed request for a team June 11, 2024 21:12
@connorjclark connorjclark changed the title core(tests): remove usage of computed PageDependencyGraph core(tests): remove usage of computed PageDependencyGraph in Lantern Jun 11, 2024
@@ -9,6 +9,9 @@ import * as TraceEngine from '@paulirish/trace_engine';
import {NetworkAnalyzer} from '../../../../lib/lantern/simulator/network-analyzer.js';
import {Simulator} from '../../../../lib/lantern/simulator/simulator.js';
import * as TraceEngineComputationData from '../../../../lib/lantern/trace-engine-computation-data.js';
import {polyfillDOMRect} from '../../../../lib/polyfill-dom-rect.js';

polyfillDOMRect();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this? Why wasn't it necessary before?

Copy link
Collaborator Author

@connorjclark connorjclark Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trace engines uses browser globals

before something was importing computed trace engine artifact which calls this

this thing shouldn't last long will get removed inside trace engine migration

@connorjclark connorjclark changed the title core(tests): remove usage of computed PageDependencyGraph in Lantern tests(lantern): remove usage of computed PageDependencyGraph Jun 11, 2024
@connorjclark connorjclark merged commit 4285e05 into main Jun 11, 2024
27 checks passed
@connorjclark connorjclark deleted the lantern-no-computed-graph branch June 11, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants