Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade typescript to 5.5.3 #16091

Merged
merged 10 commits into from
Jul 3, 2024
Merged

deps: upgrade typescript to 5.5.3 #16091

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ffa9dc6
wip
connorjclark Jul 1, 2024
4eb1ca6
trying to update
connorjclark Jun 27, 2024
9141bdb
resolve errors with process
connorjclark Jun 28, 2024
3af986d
fix clearTimeout issue
connorjclark Jun 28, 2024
365c065
workaround weird tsc bug
connorjclark Jul 1, 2024
0d37678
remove @tag test case
connorjclark Jul 1, 2024
e2e6b10
update generated/
connorjclark Jul 1, 2024
048d31f
remove some explicit type predicates
connorjclark Jul 1, 2024
2d499d7
set types/node pkg
connorjclark Jul 3, 2024
b226a2a
5.5.3
connorjclark Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions core/gather/gatherers/link-elements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,18 +94,11 @@ function getLinkElementsInDOM() {
/* c8 ignore stop */

class LinkElements extends BaseGatherer {
constructor() {
super();
/**
* This needs to be in the constructor.
* https://github.com/GoogleChrome/lighthouse/issues/12134
* @type {LH.Gatherer.GathererMeta<'DevtoolsLog'>}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was true for browserify

*/
this.meta = {
supportedModes: ['timespan', 'navigation'],
dependencies: {DevtoolsLog: DevtoolsLog.symbol},
};
}
/** @type {LH.Gatherer.GathererMeta<'DevtoolsLog'>} */
meta = {
supportedModes: ['timespan', 'navigation'],
dependencies: {DevtoolsLog: DevtoolsLog.symbol},
};

/**
* @param {LH.Gatherer.Context} context
Expand Down
Loading