Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: upgrade TS target to es2023 #16316

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

misc: upgrade TS target to es2023 #16316

wants to merge 1 commit into from

Conversation

adamraine
Copy link
Member

Gives access to findLast which is compatible with Node 18.

@adamraine adamraine requested a review from a team as a code owner January 29, 2025 21:12
@adamraine adamraine requested review from connorjclark and removed request for a team January 29, 2025 21:12
@connorjclark
Copy link
Collaborator

connorjclark commented Jan 30, 2025 •
edited
Loading

yarn build-all output:

[1] ▲ [WARNING] Unrecognized target environment "es2023" [tsconfig.json]
    tsconfig-base.json:14:14:
      14 │     "target": "es2023",
         ╵               ~~~~~~~~

@adamraine
Copy link
Member Author

Chillin till we drop Node 18 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark Awaiting requested review from connorjclark connorjclark is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
chillin ❄
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamraine @connorjclark