feat: add scoringMode to AuditResult #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Apr 5, 2017
| @@ -19,6 +19,7 @@ interface AuditFullResult { | |||
| displayValue: string; | |||
| debugString?: string; | |||
| score: boolean|number; | |||
There was a problem hiding this comment.
Should add it to the closure typedef too
ebidel
approved these changes
Apr 5, 2017
|
how do you feel about |
patrickhulce
force-pushed
the
score_precision
branch
from
7d27e4b
to
5c36aa4
Compare
patrickhulce
force-pushed
the
score_precision
branch
from
5c36aa4
to
3414327
Compare
patrickhulce
changed the title
paulirish
reviewed
Apr 5, 2017
| @@ -45,6 +45,7 @@ class TotalByteWeight extends Audit { | |||
| 'Network transfer size [costs users real dollars](https://whatdoesmysitecost.com/) ' + | |||
| 'and is [highly correlated](http://httparchive.org/interesting.php#onLoad) with long load times. ' + | |||
| 'Try to find ways to reduce the size of required files.', | |||
| scoringMode: 'numeric', | |||
There was a problem hiding this comment.
should we use an enum? scoringMode: Audit.ScoringModes.Numeric
|
Double LGTM |
brendankenny
reviewed
Apr 5, 2017
lighthouse-core/audits/audit.js
Outdated
| */ | ||
| static get ScoringModes() { | ||
| return { | ||
| Numeric: 'numeric', |
There was a problem hiding this comment.
should be NUMERIC and BINARY or numeric and binary IMO. also SCORING_MODES?
patrickhulce
force-pushed
the
score_precision
branch
from
0737440
to
7616527
Compare
|
Triple LGTM |
|
lol u guys and the yelling. lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.