Adds formatters for pretty and report outputs #301
Conversation
| class Accessibilty extends Formatter { | ||
| static getPrettyFormatter() { | ||
| return function(info) { | ||
| let output = ` - Rating: ${info.impact}\n`; |
There was a problem hiding this comment.
nit: just use a multiline string for the initial assignment.
| return this._formatters[name]; | ||
| } | ||
|
|
||
| static getPrettyFormatter() { |
There was a problem hiding this comment.
shoudl we do 1:1 matching against our --output value options? so maybe getFormatter('pretty')
There was a problem hiding this comment.
what is the story for JSON output?
There was a problem hiding this comment.
@paulirish The formatter matches the internal type, e.g. 'critical-render-path', 'accessibility', 'security'... it's essentially the formatter to use. Even if we 1:1 it, we'd still hard code the ReportGenerator to request HTML, and the CLI to request pretty, so I dunno we'd get much benefit.
There was a problem hiding this comment.
The story for JSON is that we output the extendedInfo as-is.
|
Seems good. Needs a rebase |
Fixes smoke test
Ensures that each formatter provides the right functions
Works with a11y audit atm, but this change will allow support for CRP etc.