Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: audits metadata results style #6858

Merged
merged 1 commit into from
Jan 29, 2019
Merged

report: audits metadata results style #6858

merged 1 commit into from
Jan 29, 2019

Conversation

tgfjt
Copy link
Contributor

@tgfjt tgfjt commented Dec 21, 2018

  • .lh-metadata__results with text ellipsis needs "overflow:hidden"

Summary

Before

image

After

image

Related Issues/PRs

This is related the comment.:) thanks: @exterkamp
#6833 (review)

@tgfjt
report: audits metadata results style
a72268e 
`.lh-metadata__results` with text ellipsis needs "overflow:hidden"
@tgfjt tgfjt mentioned this pull request Dec 21, 2018
Closed
brendankenny
brendankenny approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applies only to the URL and seems like exactly what we'd want for it, so LGTM :)

@brendankenny brendankenny merged commit 0cd5d2f into GoogleChrome:master Jan 29, 2019
@tgfjt tgfjt deleted the patch-2 branch February 6, 2019 00:41
@tgfjt
Copy link
Contributor Author

tgfjt commented Feb 6, 2019

@brendankenny Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgfjt @brendankenny