new_audit: json-ld audit

[mattzeunert]

Summary

Use the JSON-LD validator to audit JSON-LD snippets with Lighthouse.

Sample Lighthouse report

Related Issues/PRs

Closes #4359

[patrickhulce]

looks pretty good! hurray for splitting out the sd validation piece and making this a piece of cake to review :)

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

[mattzeunert]

 yarn build-extension && yarn build-devtools && yarn build-lr && yarn build-viewer
$ node ./build/build-extension.js
events.js:174
      throw er; // Unhandled 'error' event
      ^
Error: Cannot find module './doug-json-parse' from 'C:\projects\lighthouse\node_modules\jsonlint-mod\web'

@patrickhulce Do you have any thoughts on this failure? I know we used to have that problem, and I think it disappeared when we worked on the JSON-LD logic because that wasn't included in the bundle yet.

Browserify is trying to resolve this require:

var dougJSONParse = typeof ___dougJSONParse === 'undefined' ? require('./doug-json-parse') : ___dougJSONParse;

I can look into this more tomorrow, just wanted to check if you already have thoughts on what the solution is.

[patrickhulce]

sorry @mattzeunert not sure off the top of my head, that file is indeed missing from that directory for me, so we might need to shim something or install another dep?

[mattzeunert]

It's inlined in that file already, so there's no need to require it. Will look into convincing Browserify it's there 👍

[AVGP]

@paulirish Is there something I gotta do about the CLA or the bundlesize?

When I run yarn bundlesize locally, I get different results :/

[AVGP]

@paulirish I'm not sure what's up with the bundlesize but I think this PR is ready to move forward?

[connorjclark]

uncompressed: (2410564 - 1544755) / 1000 = +865KB to devtools bundles.
brotli: (431202 - 270410) / 1000 = +161 KB

Can expect slightly less if PR is updated to include recent build improvements.

[connorjclark]

this was rather recently superseded by another effort to bring structured data audit to LH: #12324 , so closing for that.