-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: axe-core@3.2.2 #8370
deps: axe-core@3.2.2 #8370
Conversation
Hey @paulirish! I don't work at Deque anymore, but I'm sure @WilcoFiers and @dylanb would love to know what reservations you have about the |
I think if we're unsure about the aria-hidden-focus rule we could disable it: |
Shouldn't we disable all the rules we don't have audits for anyhow? :) Yay for perf fixes!!! 🎉 |
@patrickhulce good point :) |
oh shoot! i totally knew and forgot that. my bad! dylan/wilco: mostly reservations as we're in a sprint towards tagging a new major version and i am scared of adding new audits to put in front of users that we haven't spent time with. After Google I/O we'll have more breathing room to evaluate these. ;)
for sure. brendan did the research into this back in #7127 Here's what I'm thinking:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2
This is adding 10KB after gzip to the bundle, FYI (wish bundlesize did a comparison to parent build and alerted on these things)
I found this from issue #8435 after finding a hidden label with correct https://awesome-web-react.js.org/ Seems that hidden associated labels are still showing as not linked in Lighthouse. Posting the work around below in case someone else comes across the issue. Also, I added a similar comment on the issue. /* Original version: */
label { display: none; }
/* Fix to pass Lighthouse: */
label { position: absolute; top:-1000px; left:-1000px; } |
has two perf boosts: https://github.com/dequelabs/axe-core/releases/tag/v3.2.0
3.2.0 introduced rules
aria-hidden-focus
andform-field-multiple-labels
which are tagged wcag2a (which means we'll run them now).The hidden-focus rule scares me a bit, implementation-wise, so I'm hesitant to include that in our results. The multiple-labels rule looks straightfoward.
@robdodson @marcysutton do yall have feelings on this?
fixes #7496
fixes #7355