Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add smoketest to capture microtask regression #8379

Merged
merged 9 commits into from
Apr 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ before_script:
# see comment above about puppeteer
- export CHROME_PATH="$(which google-chrome-stable)"
- sh -e /etc/init.d/xvfb start
# Print out the Chrome version so we know what we're working with
- google-chrome-stable --version
- yarn build-all
script:
Expand Down
46 changes: 46 additions & 0 deletions lighthouse-cli/test/smokehouse/perf/lantern-expectations.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,50 @@ module.exports = [
},
},
},
{
lhr: {
requestedUrl: 'http://localhost:10200/tricky-main-thread.html?setTimeout',
finalUrl: 'http://localhost:10200/tricky-main-thread.html?setTimeout',
audits: {
'interactive': {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmmmmmmmmmmm do we have to? :neckbeard:

// Make sure all of the CPU time is reflected in the perf metrics as well.
score: '<.2',
},
'bootup-time': {
details: {
items: {
0: {
// FIXME: Appveyor finds this particular assertion very flaky for some reason :(
url: process.env.APPVEYOR ? /main/ : /main-thread-consumer/,
scripting: '>1000',
},
},
},
},
},
},
},
{
lhr: {
requestedUrl: 'http://localhost:10200/tricky-main-thread.html?fetch',
finalUrl: 'http://localhost:10200/tricky-main-thread.html?fetch',
audits: {
'interactive': {
// Make sure all of the CPU time is reflected in the perf metrics as well.
score: '<.2',
},
'bootup-time': {
details: {
items: {
0: {
// TODO: requires sampling profiler and async stacks, see https://github.com/GoogleChrome/lighthouse/issues/8526
// url: /main-thread-consumer/,
scripting: '>1000',
},
},
},
},
},
},
},
];
38 changes: 0 additions & 38 deletions lighthouse-cli/test/smokehouse/tricky-metrics/expectations.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,42 +36,4 @@ module.exports = [
},
},
},
{
lhr: {
requestedUrl: 'http://localhost:10200/tricky-main-thread.html?setTimeout',
finalUrl: 'http://localhost:10200/tricky-main-thread.html?setTimeout',
audits: {
'bootup-time': {
details: {
items: {
0: {
// FIXME: Appveyor finds this particular assertion very flaky for some reason :(
url: process.env.APPVEYOR ? /main/ : /main-thread-consumer/,
scripting: '>1000',
},
},
},
},
},
},
},
{
lhr: {
requestedUrl: 'http://localhost:10200/tricky-main-thread.html?fetch',
finalUrl: 'http://localhost:10200/tricky-main-thread.html?fetch',
audits: {
'bootup-time': {
details: {
items: {
0: {
// TODO: requires async stacks, https://github.com/GoogleChrome/lighthouse/pull/5504
// url: /main-thread-consumer/,
scripting: '>1000',
},
},
},
},
},
},
},
];