-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(lightwallet): add performance-budget audit #8539
core(lightwallet): add performance-budget audit #8539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing else jumps out to me as major structural changes here, so I'll get back on the other two :)
So swift with these PRs @khempenius nice work! 💯
lighthouse-core/report/html/renderer/performance-category-renderer.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some early feedback, though obviously will be changing as it accounts for changes in the computed artifact and the other audit PR
…nto lw_resource_budget_audit
…nto lw_resource_budget_audit
…nto lw_resource_budget_audit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, just some style feedback for now.
Agreed with @paulirish on the notApplicable
fallback if there's no budget, since it looks like (until we have a default budget) the defaultTable
will just be a repeat of the resource-summary
table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
I think it still needs a yarn update:sample-json
lighthouse-core/test/report/html/renderer/category-renderer-test.js
Outdated
Show resolved
Hide resolved
I left this comment on like three other PRs as well, but the changes to |
…nto lw_resource_budget_audit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (with a few last trivial things)
with the fix, over to you @paulirish |
Updated. |
📏🐢⏱🐎⚖️🎉 |
Summary
This audit implements the budgets table.
Note: This branch also contains the code from #8522 and #8427, which are upstream dependencies.
The code changes unique to this branch are in
resource-budgets.js
andresource-budgets-test.js
.With budgets.json:
![Screen Shot 2019-04-23 at 2 35 19 AM](https://user-images.githubusercontent.com/6076184/56559774-85f9e480-6570-11e9-82b4-5e8410fa0198.png)
Without budgets.json:
![Screen Shot 2019-04-23 at 2 26 29 AM](https://user-images.githubusercontent.com/6076184/56559801-a033c280-6570-11e9-8365-58d2fa0e5724.png)
Related Issues/PRs