Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RWS-Submission_Guidelines.md #528

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samdutton
Copy link
Member

Removed first section, which is now out of date.

Minor formatting updates.

Removed first section, which is now out of date.

Minor formatting updates.
@cfredric cfredric self-requested a review September 10, 2024 15:27
Copy link
Collaborator

@cfredric cfredric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll wait to merge this in case you feel like doing some more formatting cleanups :)

A <b>subset</b> is a defined use case within a set. Set members, or domains, will always be part of a subset.
## Definitions

A **Related Website Set**, or **set**, is a collection of domains that is subject to the <a href="#set-formation-requirements">formation requirements</a>, has passed the <a href="#set-validation-requirements">validation requirements</a>, and has been successfully submitted to the canonical RWS list.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel like making more formatting updates, I think we can use Markdown syntax instead of HTML syntax for the links (here and elsewhere):

Suggested change
A **Related Website Set**, or **set**, is a collection of domains that is subject to the <a href="#set-formation-requirements">formation requirements</a>, has passed the <a href="#set-validation-requirements">validation requirements</a>, and has been successfully submitted to the canonical RWS list.
A **Related Website Set**, or **set**, is a collection of domains that is subject to the [formation requirements](#set-formation-requirements), has passed the [validation requirements](#set-validation-requirements), and has been successfully submitted to the canonical RWS list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) I'm on leave, back 19 September, but I'll have a go then (since I've started, I might as well finish!)

@@ -220,7 +226,8 @@ The /.well-known/related-website-set.json file for set members must follow the s
"required": ["primary"]
}
```
## Subset-level technical validation ##

### Subset-level technical validation

Additionally, more granular technical checks will also run on GitHub for service domains and ccTLD variants in the submissions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel like doing more formatting cleanup, we could convert the <ul> below to use markdown syntax (*).

Copy link

Looks like you've passed all of the checks!

Copy link

@ratchanonsuttawas ratchanonsuttawas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants