Skip to content

Commit

Permalink
Fix bug
Browse files Browse the repository at this point in the history
  • Loading branch information
tunetheweb committed May 2, 2024
1 parent 2c920fd commit 394e200
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
7 changes: 3 additions & 4 deletions test/e2e/onFCP-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,7 @@ describe('onFCP()', async function () {
assert.strictEqual(fcp1.value, fcp1.delta);
// Temp fix to address Firefox flakiness.
// See https://github.com/GoogleChrome/web-vitals/issues/472
console.log(':' + browser.browserName + ':');
if (browser.browserName !== 'firefox') {
if (browser.capabilities.browserName !== 'firefox') {
assert.strictEqual(fcp1.rating, 'good');
}
assert.strictEqual(fcp1.entries.length, 1);
Expand All @@ -195,7 +194,7 @@ describe('onFCP()', async function () {
assert.strictEqual(fcp2.value, fcp2.delta);
// Temp fix to address Firefox flakiness.
// See https://github.com/GoogleChrome/web-vitals/issues/472
if (browser.browserName !== 'firefox') {
if (browser.capabilities.browserName !== 'firefox') {
assert.strictEqual(fcp2.rating, 'good');
}
assert.strictEqual(fcp2.entries.length, 0);
Expand All @@ -214,7 +213,7 @@ describe('onFCP()', async function () {
assert.strictEqual(fcp3.value, fcp3.delta);
// Temp fix to address Firefox flakiness.
// See https://github.com/GoogleChrome/web-vitals/issues/472
if (browser.browserName !== 'firefox') {
if (browser.capabilities.browserName !== 'firefox') {
assert.strictEqual(fcp3.rating, 'good');
}
assert.strictEqual(fcp3.entries.length, 0);
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/onLCP-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ const assertStandardReportsAreCorrect = (beacons) => {
assert.strictEqual(lcp.value, lcp.delta);
// Temp fix to address Firefox flakiness.
// See https://github.com/GoogleChrome/web-vitals/issues/472
if (browser.browserName !== 'firefox') {
if (browser.capabilities.browserName !== 'firefox') {
assert.strictEqual(lcp.rating, 'good');
}
assert.strictEqual(lcp.entries.length, 1);
Expand Down

0 comments on commit 394e200

Please sign in to comment.